You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@whimsical.apache.org by "Sebb (JIRA)" <ji...@apache.org> on 2017/06/23 15:26:00 UTC

[jira] [Commented] (WHIMSY-109) Code uses Dir.chdir and Dir.pwd without sync

    [ https://issues.apache.org/jira/browse/WHIMSY-109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16061118#comment-16061118 ] 

Sebb commented on WHIMSY-109:
-----------------------------

I'm looking into whether it's possible to tell the command shell to start the git/svn process in a different directory.
That would avoid the need to do it in the parent process.

> Code uses Dir.chdir and Dir.pwd without sync
> --------------------------------------------
>
>                 Key: WHIMSY-109
>                 URL: https://issues.apache.org/jira/browse/WHIMSY-109
>             Project: Whimsy
>          Issue Type: Bug
>            Reporter: Sebb
>            Assignee: Sebb
>
> The lib/whimsy code uses Dir.chdir in two places:
> asf/git.rb and svn.rb
> These are done under Mutex synchronisation.
> However AFAICT they use different instances of the Mutex.
> Also, there is an instance of Dir.pwd in the file asf/rack.rb
> This does not use a Mutex at all.
> So unless there is some other mutual exclusion occurring, there is a potential for confusion over the actual working directory.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)