You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/01/10 02:37:08 UTC
Review Request 65060: Cleaned up endpoint directories after SLRP
tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65060/
-----------------------------------------------------------
Review request for mesos, Gaston Kleiman, Greg Mann, and Jie Yu.
Repository: mesos
Description
-------
Cleaned up endpoint directories after SLRP tests.
Diffs
-----
src/tests/storage_local_resource_provider_tests.cpp bbfe95e9818f25fdd5405db3ad2fe355e023f743
Diff: https://reviews.apache.org/r/65060/diff/1/
Testing
-------
sudo make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 65060: Cleaned up endpoint directories after SLRP
tests.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
> On Jan. 19, 2018, 11:30 p.m., Greg Mann wrote:
> > src/tests/storage_local_resource_provider_tests.cpp
> > Lines 210-233 (patched)
> > <https://reviews.apache.org/r/65060/diff/1/?file=1938029#file1938029line210>
> >
> > As we discussed offline, it would be great if we can move this into the test fixture's `TearDown()` method.
Instead of handling this in `TearDown()`, I move this to `cluster::Slave::~Slave()`, since the clean-up depends on the agent's work dir.
- Chun-Hung
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65060/#review195860
-----------------------------------------------------------
On Jan. 10, 2018, 2:37 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65060/
> -----------------------------------------------------------
>
> (Updated Jan. 10, 2018, 2:37 a.m.)
>
>
> Review request for mesos, Gaston Kleiman, Greg Mann, and Jie Yu.
>
>
> Bugs: MESOS-8427
> https://issues.apache.org/jira/browse/MESOS-8427
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Cleaned up endpoint directories after SLRP tests.
>
>
> Diffs
> -----
>
> src/tests/storage_local_resource_provider_tests.cpp 5ac91802e7c79e769c59c8418502ccc9d41f51b4
>
>
> Diff: https://reviews.apache.org/r/65060/diff/2/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 65060: Cleaned up endpoint directories after SLRP
tests.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65060/#review195860
-----------------------------------------------------------
src/tests/storage_local_resource_provider_tests.cpp
Lines 210-233 (patched)
<https://reviews.apache.org/r/65060/#comment275198>
As we discussed offline, it would be great if we can move this into the test fixture's `TearDown()` method.
- Greg Mann
On Jan. 10, 2018, 2:37 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65060/
> -----------------------------------------------------------
>
> (Updated Jan. 10, 2018, 2:37 a.m.)
>
>
> Review request for mesos, Gaston Kleiman, Greg Mann, and Jie Yu.
>
>
> Bugs: MESOS-8427
> https://issues.apache.org/jira/browse/MESOS-8427
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Cleaned up endpoint directories after SLRP tests.
>
>
> Diffs
> -----
>
> src/tests/storage_local_resource_provider_tests.cpp bbfe95e9818f25fdd5405db3ad2fe355e023f743
>
>
> Diff: https://reviews.apache.org/r/65060/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 65060: Cleaned up endpoint directories after SLRP
tests.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65060/#review196941
-----------------------------------------------------------
src/tests/cluster.cpp
Lines 685 (patched)
<https://reviews.apache.org/r/65060/#comment276931>
Can we move to the SLRP test fixture? I don't think it's maintainable to have all cleanup code in a single place.
For instance, CNI test cleanup code is very networking related, better to put in CNI test fixtures, not in a global location.
- Jie Yu
On Feb. 3, 2018, 1:37 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65060/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2018, 1:37 a.m.)
>
>
> Review request for mesos, Gaston Kleiman, Greg Mann, and Jie Yu.
>
>
> Bugs: MESOS-8427
> https://issues.apache.org/jira/browse/MESOS-8427
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Cleaned up endpoint directories after SLRP tests.
>
>
> Diffs
> -----
>
> src/tests/cluster.cpp 19a41c7c1c303ad806daa4e5e3765a1e0b55933b
>
>
> Diff: https://reviews.apache.org/r/65060/diff/5/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 65060: Cleaned up endpoint directories after SLRP
tests.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65060/#review197062
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Feb. 7, 2018, 6:37 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65060/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2018, 6:37 p.m.)
>
>
> Review request for mesos, Gaston Kleiman, Greg Mann, and Jie Yu.
>
>
> Bugs: MESOS-8427
> https://issues.apache.org/jira/browse/MESOS-8427
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Cleaned up endpoint directories after SLRP tests.
>
>
> Diffs
> -----
>
> src/tests/storage_local_resource_provider_tests.cpp ce241617ee555e5a67e552dd30b0e7afee161386
>
>
> Diff: https://reviews.apache.org/r/65060/diff/7/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 65060: Cleaned up endpoint directories after SLRP
tests.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65060/
-----------------------------------------------------------
(Updated Feb. 7, 2018, 6:37 p.m.)
Review request for mesos, Gaston Kleiman, Greg Mann, and Jie Yu.
Changes
-------
Handled multiple `CreateSlaveFlags()` calls.
Bugs: MESOS-8427
https://issues.apache.org/jira/browse/MESOS-8427
Repository: mesos
Description
-------
Cleaned up endpoint directories after SLRP tests.
Diffs (updated)
-----
src/tests/storage_local_resource_provider_tests.cpp ce241617ee555e5a67e552dd30b0e7afee161386
Diff: https://reviews.apache.org/r/65060/diff/7/
Changes: https://reviews.apache.org/r/65060/diff/6-7/
Testing
-------
sudo make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 65060: Cleaned up endpoint directories after SLRP
tests.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65060/
-----------------------------------------------------------
(Updated Feb. 7, 2018, 6:15 p.m.)
Review request for mesos, Gaston Kleiman, Greg Mann, and Jie Yu.
Changes
-------
Addressed Jie's comment.
Bugs: MESOS-8427
https://issues.apache.org/jira/browse/MESOS-8427
Repository: mesos
Description
-------
Cleaned up endpoint directories after SLRP tests.
Diffs (updated)
-----
src/tests/storage_local_resource_provider_tests.cpp ce241617ee555e5a67e552dd30b0e7afee161386
Diff: https://reviews.apache.org/r/65060/diff/6/
Changes: https://reviews.apache.org/r/65060/diff/5-6/
Testing
-------
sudo make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 65060: Cleaned up endpoint directories after SLRP
tests.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65060/
-----------------------------------------------------------
(Updated Feb. 3, 2018, 1:37 a.m.)
Review request for mesos, Gaston Kleiman, Greg Mann, and Jie Yu.
Bugs: MESOS-8427
https://issues.apache.org/jira/browse/MESOS-8427
Repository: mesos
Description
-------
Cleaned up endpoint directories after SLRP tests.
Diffs (updated)
-----
src/tests/cluster.cpp 19a41c7c1c303ad806daa4e5e3765a1e0b55933b
Diff: https://reviews.apache.org/r/65060/diff/5/
Changes: https://reviews.apache.org/r/65060/diff/4-5/
Testing
-------
sudo make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 65060: Cleaned up endpoint directories after SLRP
tests.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65060/
-----------------------------------------------------------
(Updated Feb. 2, 2018, 5:25 a.m.)
Review request for mesos, Gaston Kleiman, Greg Mann, and Jie Yu.
Changes
-------
Addressed Greg's comment.
Bugs: MESOS-8427
https://issues.apache.org/jira/browse/MESOS-8427
Repository: mesos
Description
-------
Cleaned up endpoint directories after SLRP tests.
Diffs (updated)
-----
src/tests/cluster.cpp 19a41c7c1c303ad806daa4e5e3765a1e0b55933b
src/tests/storage_local_resource_provider_tests.cpp 85eaef877cb3d62aed0eb2bd5adfba8007c3ee76
Diff: https://reviews.apache.org/r/65060/diff/3/
Changes: https://reviews.apache.org/r/65060/diff/2-3/
Testing
-------
sudo make check
Thanks,
Chun-Hung Hsiao