You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Mirko Friedenhagen (JIRA)" <ji...@codehaus.org> on 2011/12/01 21:19:39 UTC
[jira] Created: (MSKINS-15) With sidebar and no topbar external
links should be rendered as menu
With sidebar and no topbar external links should be rendered as menu
--------------------------------------------------------------------
Key: MSKINS-15
URL: https://jira.codehaus.org/browse/MSKINS-15
Project: Maven Skins
Issue Type: Improvement
Components: Fluido Skin
Affects Versions: fluido-1.0, fluido-1.1
Environment: {code}
mvn --version
Apache Maven 3.0.4 (r1209000; 2011-12-01 09:49:38+0100)
Maven home: /usr/local/Cellar/maven/current/libexec
Java version: 1.6.0_29, vendor: Apple Inc.
Java home: /Library/Java/JavaVirtualMachines/1.6.0_29-b11-402.jdk/Contents/Home
Default locale: de_DE, platform encoding: MacRoman
OS name: "mac os x", version: "10.7.2", arch: "x86_64", family: "mac"
{code}
Reporter: Mirko Friedenhagen
Attachments: enable-external-links-for-sidebar-when-no-topbar.patch
External links specified in {{//project/body/links}} of the {{site.xml}} are only rendered as dropdown menu when the topbar is enabled.
When only the sidebar is enabled these links are missing completely. I have attached a patch against revision 1206640 of http://svn.apache.org/repos/asf/maven/skins/trunk/maven-fluido-skin, which will render these links as additional menu in the sidebar when {{topbarEnabled==false}} and {{sidebarEnabled==true}}.
Example output might be found at http://mojo.codehaus.org/fluido-preview/ for the ckjm-maven-plugin.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MSKINS-15) With sidebar and no topbar external
links should be rendered as menu
Posted by "Robert Scholte (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MSKINS-15?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Scholte closed MSKINS-15.
--------------------------------
Resolution: Fixed
Fixed in [rev. 1211671|http://svn.apache.org/viewvc?rev=1211671&view=rev] together with headers for the custom options
> With sidebar and no topbar external links should be rendered as menu
> --------------------------------------------------------------------
>
> Key: MSKINS-15
> URL: https://jira.codehaus.org/browse/MSKINS-15
> Project: Maven Skins
> Issue Type: Improvement
> Components: Fluido Skin
> Affects Versions: fluido-1.0, fluido-1.1
> Environment: {code}
> mvn --version
> Apache Maven 3.0.4 (r1209000; 2011-12-01 09:49:38+0100)
> Maven home: /usr/local/Cellar/maven/current/libexec
> Java version: 1.6.0_29, vendor: Apple Inc.
> Java home: /Library/Java/JavaVirtualMachines/1.6.0_29-b11-402.jdk/Contents/Home
> Default locale: de_DE, platform encoding: MacRoman
> OS name: "mac os x", version: "10.7.2", arch: "x86_64", family: "mac"
> {code}
> Reporter: Mirko Friedenhagen
> Assignee: Robert Scholte
> Fix For: fluido-1.1
>
> Attachments: documentation.patch, enable-external-links-for-sidebar-when-no-topbar.patch
>
>
> External links specified in {{//project/body/links}} of the {{site.xml}} are only rendered as dropdown menu when the topbar is enabled.
> When only the sidebar is enabled these links are missing completely. I have attached a patch against revision 1206640 of http://svn.apache.org/repos/asf/maven/skins/trunk/maven-fluido-skin, which will render these links as additional menu in the sidebar when {{topbarEnabled==false}} and {{sidebarEnabled==true}}.
> Example output might be found at http://mojo.codehaus.org/fluido-preview/ for the ckjm-maven-plugin.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MSKINS-15) With sidebar and no topbar external
links should be rendered as menu
Posted by "Robert Scholte (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MSKINS-15?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=285177#comment-285177 ]
Robert Scholte commented on MSKINS-15:
--------------------------------------
Looks to me we've got a new problem: when both bars are rendered, the sidebar is missing the links, right?
> With sidebar and no topbar external links should be rendered as menu
> --------------------------------------------------------------------
>
> Key: MSKINS-15
> URL: https://jira.codehaus.org/browse/MSKINS-15
> Project: Maven Skins
> Issue Type: Improvement
> Components: Fluido Skin
> Affects Versions: fluido-1.0, fluido-1.1
> Environment: {code}
> mvn --version
> Apache Maven 3.0.4 (r1209000; 2011-12-01 09:49:38+0100)
> Maven home: /usr/local/Cellar/maven/current/libexec
> Java version: 1.6.0_29, vendor: Apple Inc.
> Java home: /Library/Java/JavaVirtualMachines/1.6.0_29-b11-402.jdk/Contents/Home
> Default locale: de_DE, platform encoding: MacRoman
> OS name: "mac os x", version: "10.7.2", arch: "x86_64", family: "mac"
> {code}
> Reporter: Mirko Friedenhagen
> Assignee: Robert Scholte
> Attachments: enable-external-links-for-sidebar-when-no-topbar.patch
>
>
> External links specified in {{//project/body/links}} of the {{site.xml}} are only rendered as dropdown menu when the topbar is enabled.
> When only the sidebar is enabled these links are missing completely. I have attached a patch against revision 1206640 of http://svn.apache.org/repos/asf/maven/skins/trunk/maven-fluido-skin, which will render these links as additional menu in the sidebar when {{topbarEnabled==false}} and {{sidebarEnabled==true}}.
> Example output might be found at http://mojo.codehaus.org/fluido-preview/ for the ckjm-maven-plugin.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Reopened: (MSKINS-15) With sidebar and no topbar external
links should be rendered as menu
Posted by "Robert Scholte (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MSKINS-15?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Scholte reopened MSKINS-15:
----------------------------------
> With sidebar and no topbar external links should be rendered as menu
> --------------------------------------------------------------------
>
> Key: MSKINS-15
> URL: https://jira.codehaus.org/browse/MSKINS-15
> Project: Maven Skins
> Issue Type: Improvement
> Components: Fluido Skin
> Affects Versions: fluido-1.0, fluido-1.1
> Environment: {code}
> mvn --version
> Apache Maven 3.0.4 (r1209000; 2011-12-01 09:49:38+0100)
> Maven home: /usr/local/Cellar/maven/current/libexec
> Java version: 1.6.0_29, vendor: Apple Inc.
> Java home: /Library/Java/JavaVirtualMachines/1.6.0_29-b11-402.jdk/Contents/Home
> Default locale: de_DE, platform encoding: MacRoman
> OS name: "mac os x", version: "10.7.2", arch: "x86_64", family: "mac"
> {code}
> Reporter: Mirko Friedenhagen
> Assignee: Robert Scholte
> Fix For: fluido-1.1
>
> Attachments: documentation.patch, enable-external-links-for-sidebar-when-no-topbar.patch
>
>
> External links specified in {{//project/body/links}} of the {{site.xml}} are only rendered as dropdown menu when the topbar is enabled.
> When only the sidebar is enabled these links are missing completely. I have attached a patch against revision 1206640 of http://svn.apache.org/repos/asf/maven/skins/trunk/maven-fluido-skin, which will render these links as additional menu in the sidebar when {{topbarEnabled==false}} and {{sidebarEnabled==true}}.
> Example output might be found at http://mojo.codehaus.org/fluido-preview/ for the ckjm-maven-plugin.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Issue Comment Edited: (MSKINS-15) With sidebar and no topbar
external links should be rendered as menu
Posted by "Mirko Friedenhagen (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MSKINS-15?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=285188#comment-285188 ]
Mirko Friedenhagen edited comment on MSKINS-15 at 12/7/11 4:43 PM:
-------------------------------------------------------------------
I created a verify.bsh script which will check the existence of the links after rendition. You have to copy this to src/it/mskins-15/
was (Author: mfriedenhagen):
I created a verify.bsh Skript which will check the existence of the links after rendition. You have to copy this to src/it/mskins-15/
> With sidebar and no topbar external links should be rendered as menu
> --------------------------------------------------------------------
>
> Key: MSKINS-15
> URL: https://jira.codehaus.org/browse/MSKINS-15
> Project: Maven Skins
> Issue Type: Bug
> Components: Fluido Skin
> Affects Versions: fluido-1.0, fluido-1.1
> Environment: mvn --version
> Apache Maven 3.0.4 (r1209000; 2011-12-01 09:49:38+0100)
> Maven home: /usr/local/Cellar/maven/current/libexec
> Java version: 1.6.0_29, vendor: Apple Inc.
> Java home: /Library/Java/JavaVirtualMachines/1.6.0_29-b11-402.jdk/Contents/Home
> Default locale: de_DE, platform encoding: MacRoman
> OS name: "mac os x", version: "10.7.2", arch: "x86_64", family: "mac"
> Reporter: Mirko Friedenhagen
> Assignee: Robert Scholte
> Fix For: fluido-1.1
>
> Attachments: documentation.patch, enable-external-links-for-sidebar-when-no-topbar.patch, verify.bsh
>
>
> External links specified in {{//project/body/links}} of the {{site.xml}} are only rendered as dropdown menu when the topbar is enabled.
> When only the sidebar is enabled these links are missing completely. I have attached a patch against revision 1206640 of http://svn.apache.org/repos/asf/maven/skins/trunk/maven-fluido-skin, which will render these links as additional menu in the sidebar when {{topbarEnabled==false}} and {{sidebarEnabled==true}}.
> Example output might be found at http://mojo.codehaus.org/fluido-preview/ for the ckjm-maven-plugin.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MSKINS-15) With sidebar and no topbar external links should
be rendered as menu
Posted by "Robert Scholte (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MSKINS-15?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=285765#comment-285765 ]
Robert Scholte commented on MSKINS-15:
--------------------------------------
I agree. Go ahead and patch it. This issue has an IT with verification script, so it's easy to confirm the fix.
> With sidebar and no topbar external links should be rendered as menu
> --------------------------------------------------------------------
>
> Key: MSKINS-15
> URL: https://jira.codehaus.org/browse/MSKINS-15
> Project: Maven Skins
> Issue Type: Bug
> Components: Fluido Skin
> Affects Versions: fluido-1.0, fluido-1.1
> Environment: mvn --version
> Apache Maven 3.0.4 (r1209000; 2011-12-01 09:49:38+0100)
> Maven home: /usr/local/Cellar/maven/current/libexec
> Java version: 1.6.0_29, vendor: Apple Inc.
> Java home: /Library/Java/JavaVirtualMachines/1.6.0_29-b11-402.jdk/Contents/Home
> Default locale: de_DE, platform encoding: MacRoman
> OS name: "mac os x", version: "10.7.2", arch: "x86_64", family: "mac"
> Reporter: Mirko Friedenhagen
> Assignee: Robert Scholte
> Fix For: fluido-1.1
>
> Attachments: documentation.patch, enable-external-links-for-sidebar-when-no-topbar.patch, verify.bsh
>
>
> External links specified in {{//project/body/links}} of the {{site.xml}} are only rendered as dropdown menu when the topbar is enabled.
> When only the sidebar is enabled these links are missing completely. I have attached a patch against revision 1206640 of http://svn.apache.org/repos/asf/maven/skins/trunk/maven-fluido-skin, which will render these links as additional menu in the sidebar when {{topbarEnabled==false}} and {{sidebarEnabled==true}}.
> Example output might be found at http://mojo.codehaus.org/fluido-preview/ for the ckjm-maven-plugin.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MSKINS-15) With sidebar and no topbar external links should
be rendered as menu
Posted by "Simone Tripodi (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MSKINS-15?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=285759#comment-285759 ]
Simone Tripodi commented on MSKINS-15:
--------------------------------------
We got a new contribution about this issue that IMHO solves the problem in a more canonical Maven way, please see [MSKINS-19|https://jira.codehaus.org/browse/MSKINS-19].
WDYT?
> With sidebar and no topbar external links should be rendered as menu
> --------------------------------------------------------------------
>
> Key: MSKINS-15
> URL: https://jira.codehaus.org/browse/MSKINS-15
> Project: Maven Skins
> Issue Type: Bug
> Components: Fluido Skin
> Affects Versions: fluido-1.0, fluido-1.1
> Environment: mvn --version
> Apache Maven 3.0.4 (r1209000; 2011-12-01 09:49:38+0100)
> Maven home: /usr/local/Cellar/maven/current/libexec
> Java version: 1.6.0_29, vendor: Apple Inc.
> Java home: /Library/Java/JavaVirtualMachines/1.6.0_29-b11-402.jdk/Contents/Home
> Default locale: de_DE, platform encoding: MacRoman
> OS name: "mac os x", version: "10.7.2", arch: "x86_64", family: "mac"
> Reporter: Mirko Friedenhagen
> Assignee: Robert Scholte
> Fix For: fluido-1.1
>
> Attachments: documentation.patch, enable-external-links-for-sidebar-when-no-topbar.patch, verify.bsh
>
>
> External links specified in {{//project/body/links}} of the {{site.xml}} are only rendered as dropdown menu when the topbar is enabled.
> When only the sidebar is enabled these links are missing completely. I have attached a patch against revision 1206640 of http://svn.apache.org/repos/asf/maven/skins/trunk/maven-fluido-skin, which will render these links as additional menu in the sidebar when {{topbarEnabled==false}} and {{sidebarEnabled==true}}.
> Example output might be found at http://mojo.codehaus.org/fluido-preview/ for the ckjm-maven-plugin.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Issue Comment Edited: (MSKINS-15) With sidebar and no topbar
external links should be rendered as menu
Posted by "Mirko Friedenhagen (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MSKINS-15?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=285178#comment-285178 ]
Mirko Friedenhagen edited comment on MSKINS-15 at 12/7/11 3:14 PM:
-------------------------------------------------------------------
No, this works as intended :-). The inverse logic applies to the google search box. I am not sure, wether we should make this configurable. Having both the top- and sidebar is confusing anyway IMO :-).
was (Author: mfriedenhagen):
No, this works as intended :-). The same logic applies to the google search box.
> With sidebar and no topbar external links should be rendered as menu
> --------------------------------------------------------------------
>
> Key: MSKINS-15
> URL: https://jira.codehaus.org/browse/MSKINS-15
> Project: Maven Skins
> Issue Type: Improvement
> Components: Fluido Skin
> Affects Versions: fluido-1.0, fluido-1.1
> Environment: {code}
> mvn --version
> Apache Maven 3.0.4 (r1209000; 2011-12-01 09:49:38+0100)
> Maven home: /usr/local/Cellar/maven/current/libexec
> Java version: 1.6.0_29, vendor: Apple Inc.
> Java home: /Library/Java/JavaVirtualMachines/1.6.0_29-b11-402.jdk/Contents/Home
> Default locale: de_DE, platform encoding: MacRoman
> OS name: "mac os x", version: "10.7.2", arch: "x86_64", family: "mac"
> {code}
> Reporter: Mirko Friedenhagen
> Assignee: Robert Scholte
> Attachments: enable-external-links-for-sidebar-when-no-topbar.patch
>
>
> External links specified in {{//project/body/links}} of the {{site.xml}} are only rendered as dropdown menu when the topbar is enabled.
> When only the sidebar is enabled these links are missing completely. I have attached a patch against revision 1206640 of http://svn.apache.org/repos/asf/maven/skins/trunk/maven-fluido-skin, which will render these links as additional menu in the sidebar when {{topbarEnabled==false}} and {{sidebarEnabled==true}}.
> Example output might be found at http://mojo.codehaus.org/fluido-preview/ for the ckjm-maven-plugin.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MSKINS-15) With sidebar and no topbar external
links should be rendered as menu
Posted by "Mirko Friedenhagen (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MSKINS-15?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=285178#comment-285178 ]
Mirko Friedenhagen commented on MSKINS-15:
------------------------------------------
No, this works as intended :-). The same logic applies to the google search box.
> With sidebar and no topbar external links should be rendered as menu
> --------------------------------------------------------------------
>
> Key: MSKINS-15
> URL: https://jira.codehaus.org/browse/MSKINS-15
> Project: Maven Skins
> Issue Type: Improvement
> Components: Fluido Skin
> Affects Versions: fluido-1.0, fluido-1.1
> Environment: {code}
> mvn --version
> Apache Maven 3.0.4 (r1209000; 2011-12-01 09:49:38+0100)
> Maven home: /usr/local/Cellar/maven/current/libexec
> Java version: 1.6.0_29, vendor: Apple Inc.
> Java home: /Library/Java/JavaVirtualMachines/1.6.0_29-b11-402.jdk/Contents/Home
> Default locale: de_DE, platform encoding: MacRoman
> OS name: "mac os x", version: "10.7.2", arch: "x86_64", family: "mac"
> {code}
> Reporter: Mirko Friedenhagen
> Assignee: Robert Scholte
> Attachments: enable-external-links-for-sidebar-when-no-topbar.patch
>
>
> External links specified in {{//project/body/links}} of the {{site.xml}} are only rendered as dropdown menu when the topbar is enabled.
> When only the sidebar is enabled these links are missing completely. I have attached a patch against revision 1206640 of http://svn.apache.org/repos/asf/maven/skins/trunk/maven-fluido-skin, which will render these links as additional menu in the sidebar when {{topbarEnabled==false}} and {{sidebarEnabled==true}}.
> Example output might be found at http://mojo.codehaus.org/fluido-preview/ for the ckjm-maven-plugin.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MSKINS-15) With sidebar and no topbar external
links should be rendered as menu
Posted by "Mirko Friedenhagen (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MSKINS-15?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mirko Friedenhagen updated MSKINS-15:
-------------------------------------
Attachment: verify.bsh
I created a verify.bsh Skript which will check the existence of the links after rendition. You have to copy this to src/it/mskins-15/
> With sidebar and no topbar external links should be rendered as menu
> --------------------------------------------------------------------
>
> Key: MSKINS-15
> URL: https://jira.codehaus.org/browse/MSKINS-15
> Project: Maven Skins
> Issue Type: Bug
> Components: Fluido Skin
> Affects Versions: fluido-1.0, fluido-1.1
> Environment: mvn --version
> Apache Maven 3.0.4 (r1209000; 2011-12-01 09:49:38+0100)
> Maven home: /usr/local/Cellar/maven/current/libexec
> Java version: 1.6.0_29, vendor: Apple Inc.
> Java home: /Library/Java/JavaVirtualMachines/1.6.0_29-b11-402.jdk/Contents/Home
> Default locale: de_DE, platform encoding: MacRoman
> OS name: "mac os x", version: "10.7.2", arch: "x86_64", family: "mac"
> Reporter: Mirko Friedenhagen
> Assignee: Robert Scholte
> Fix For: fluido-1.1
>
> Attachments: documentation.patch, enable-external-links-for-sidebar-when-no-topbar.patch, verify.bsh
>
>
> External links specified in {{//project/body/links}} of the {{site.xml}} are only rendered as dropdown menu when the topbar is enabled.
> When only the sidebar is enabled these links are missing completely. I have attached a patch against revision 1206640 of http://svn.apache.org/repos/asf/maven/skins/trunk/maven-fluido-skin, which will render these links as additional menu in the sidebar when {{topbarEnabled==false}} and {{sidebarEnabled==true}}.
> Example output might be found at http://mojo.codehaus.org/fluido-preview/ for the ckjm-maven-plugin.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MSKINS-15) With sidebar and no topbar external
links should be rendered as menu
Posted by "Robert Scholte (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MSKINS-15?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=285234#comment-285234 ]
Robert Scholte commented on MSKINS-15:
--------------------------------------
I thought you'd preferred groovy? ;) I'll translate it, thnx!
> With sidebar and no topbar external links should be rendered as menu
> --------------------------------------------------------------------
>
> Key: MSKINS-15
> URL: https://jira.codehaus.org/browse/MSKINS-15
> Project: Maven Skins
> Issue Type: Bug
> Components: Fluido Skin
> Affects Versions: fluido-1.0, fluido-1.1
> Environment: mvn --version
> Apache Maven 3.0.4 (r1209000; 2011-12-01 09:49:38+0100)
> Maven home: /usr/local/Cellar/maven/current/libexec
> Java version: 1.6.0_29, vendor: Apple Inc.
> Java home: /Library/Java/JavaVirtualMachines/1.6.0_29-b11-402.jdk/Contents/Home
> Default locale: de_DE, platform encoding: MacRoman
> OS name: "mac os x", version: "10.7.2", arch: "x86_64", family: "mac"
> Reporter: Mirko Friedenhagen
> Assignee: Robert Scholte
> Fix For: fluido-1.1
>
> Attachments: documentation.patch, enable-external-links-for-sidebar-when-no-topbar.patch, verify.bsh
>
>
> External links specified in {{//project/body/links}} of the {{site.xml}} are only rendered as dropdown menu when the topbar is enabled.
> When only the sidebar is enabled these links are missing completely. I have attached a patch against revision 1206640 of http://svn.apache.org/repos/asf/maven/skins/trunk/maven-fluido-skin, which will render these links as additional menu in the sidebar when {{topbarEnabled==false}} and {{sidebarEnabled==true}}.
> Example output might be found at http://mojo.codehaus.org/fluido-preview/ for the ckjm-maven-plugin.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MSKINS-15) With sidebar and no topbar external
links should be rendered as menu
Posted by "Simone Tripodi (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MSKINS-15?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=284831#comment-284831 ]
Simone Tripodi commented on MSKINS-15:
--------------------------------------
thanks a lot for your patch Mirko! it has bee applied on {{trunk}}, see [r1210036|https://svn.apache.org/viewvc?view=revision&revision=1210036].
Thanks again, very appreciated!
> With sidebar and no topbar external links should be rendered as menu
> --------------------------------------------------------------------
>
> Key: MSKINS-15
> URL: https://jira.codehaus.org/browse/MSKINS-15
> Project: Maven Skins
> Issue Type: Improvement
> Components: Fluido Skin
> Affects Versions: fluido-1.0, fluido-1.1
> Environment: {code}
> mvn --version
> Apache Maven 3.0.4 (r1209000; 2011-12-01 09:49:38+0100)
> Maven home: /usr/local/Cellar/maven/current/libexec
> Java version: 1.6.0_29, vendor: Apple Inc.
> Java home: /Library/Java/JavaVirtualMachines/1.6.0_29-b11-402.jdk/Contents/Home
> Default locale: de_DE, platform encoding: MacRoman
> OS name: "mac os x", version: "10.7.2", arch: "x86_64", family: "mac"
> {code}
> Reporter: Mirko Friedenhagen
> Attachments: enable-external-links-for-sidebar-when-no-topbar.patch
>
>
> External links specified in {{//project/body/links}} of the {{site.xml}} are only rendered as dropdown menu when the topbar is enabled.
> When only the sidebar is enabled these links are missing completely. I have attached a patch against revision 1206640 of http://svn.apache.org/repos/asf/maven/skins/trunk/maven-fluido-skin, which will render these links as additional menu in the sidebar when {{topbarEnabled==false}} and {{sidebarEnabled==true}}.
> Example output might be found at http://mojo.codehaus.org/fluido-preview/ for the ckjm-maven-plugin.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MSKINS-15) With sidebar and no topbar external links should
be rendered as menu
Posted by "Simone Tripodi (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MSKINS-15?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=286494#comment-286494 ]
Simone Tripodi commented on MSKINS-15:
--------------------------------------
Fixed once for all, see [r1221707|https://svn.apache.org/viewvc?view=revision&revision=1221707].
Please review! :)
> With sidebar and no topbar external links should be rendered as menu
> --------------------------------------------------------------------
>
> Key: MSKINS-15
> URL: https://jira.codehaus.org/browse/MSKINS-15
> Project: Maven Skins
> Issue Type: Bug
> Components: Fluido Skin
> Affects Versions: fluido-1.0, fluido-1.1
> Environment: mvn --version
> Apache Maven 3.0.4 (r1209000; 2011-12-01 09:49:38+0100)
> Maven home: /usr/local/Cellar/maven/current/libexec
> Java version: 1.6.0_29, vendor: Apple Inc.
> Java home: /Library/Java/JavaVirtualMachines/1.6.0_29-b11-402.jdk/Contents/Home
> Default locale: de_DE, platform encoding: MacRoman
> OS name: "mac os x", version: "10.7.2", arch: "x86_64", family: "mac"
> Reporter: Mirko Friedenhagen
> Assignee: Robert Scholte
> Fix For: fluido-1.1
>
> Attachments: documentation.patch, enable-external-links-for-sidebar-when-no-topbar.patch, verify.bsh
>
>
> External links specified in {{//project/body/links}} of the {{site.xml}} are only rendered as dropdown menu when the topbar is enabled.
> When only the sidebar is enabled these links are missing completely. I have attached a patch against revision 1206640 of http://svn.apache.org/repos/asf/maven/skins/trunk/maven-fluido-skin, which will render these links as additional menu in the sidebar when {{topbarEnabled==false}} and {{sidebarEnabled==true}}.
> Example output might be found at http://mojo.codehaus.org/fluido-preview/ for the ckjm-maven-plugin.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MSKINS-15) With sidebar and no topbar external
links should be rendered as menu
Posted by "Robert Scholte (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MSKINS-15?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Scholte closed MSKINS-15.
--------------------------------
Resolution: Fixed
Fix Version/s: fluido-1.1
Added IT in [rev. 1211638|http://svn.apache.org/viewvc?rev=1211638&view=rev]
Let's close this issue. Anyone who wants to discuss the preferred position of the googleSearch can create a new issue;)
> With sidebar and no topbar external links should be rendered as menu
> --------------------------------------------------------------------
>
> Key: MSKINS-15
> URL: https://jira.codehaus.org/browse/MSKINS-15
> Project: Maven Skins
> Issue Type: Improvement
> Components: Fluido Skin
> Affects Versions: fluido-1.0, fluido-1.1
> Environment: {code}
> mvn --version
> Apache Maven 3.0.4 (r1209000; 2011-12-01 09:49:38+0100)
> Maven home: /usr/local/Cellar/maven/current/libexec
> Java version: 1.6.0_29, vendor: Apple Inc.
> Java home: /Library/Java/JavaVirtualMachines/1.6.0_29-b11-402.jdk/Contents/Home
> Default locale: de_DE, platform encoding: MacRoman
> OS name: "mac os x", version: "10.7.2", arch: "x86_64", family: "mac"
> {code}
> Reporter: Mirko Friedenhagen
> Assignee: Robert Scholte
> Fix For: fluido-1.1
>
> Attachments: enable-external-links-for-sidebar-when-no-topbar.patch
>
>
> External links specified in {{//project/body/links}} of the {{site.xml}} are only rendered as dropdown menu when the topbar is enabled.
> When only the sidebar is enabled these links are missing completely. I have attached a patch against revision 1206640 of http://svn.apache.org/repos/asf/maven/skins/trunk/maven-fluido-skin, which will render these links as additional menu in the sidebar when {{topbarEnabled==false}} and {{sidebarEnabled==true}}.
> Example output might be found at http://mojo.codehaus.org/fluido-preview/ for the ckjm-maven-plugin.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MSKINS-15) With sidebar and no topbar external
links should be rendered as menu
Posted by "Robert Scholte (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MSKINS-15?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Scholte updated MSKINS-15:
---------------------------------
Environment:
mvn --version
Apache Maven 3.0.4 (r1209000; 2011-12-01 09:49:38+0100)
Maven home: /usr/local/Cellar/maven/current/libexec
Java version: 1.6.0_29, vendor: Apple Inc.
Java home: /Library/Java/JavaVirtualMachines/1.6.0_29-b11-402.jdk/Contents/Home
Default locale: de_DE, platform encoding: MacRoman
OS name: "mac os x", version: "10.7.2", arch: "x86_64", family: "mac"
was:
{code}
mvn --version
Apache Maven 3.0.4 (r1209000; 2011-12-01 09:49:38+0100)
Maven home: /usr/local/Cellar/maven/current/libexec
Java version: 1.6.0_29, vendor: Apple Inc.
Java home: /Library/Java/JavaVirtualMachines/1.6.0_29-b11-402.jdk/Contents/Home
Default locale: de_DE, platform encoding: MacRoman
OS name: "mac os x", version: "10.7.2", arch: "x86_64", family: "mac"
{code}
> With sidebar and no topbar external links should be rendered as menu
> --------------------------------------------------------------------
>
> Key: MSKINS-15
> URL: https://jira.codehaus.org/browse/MSKINS-15
> Project: Maven Skins
> Issue Type: Improvement
> Components: Fluido Skin
> Affects Versions: fluido-1.0, fluido-1.1
> Environment: mvn --version
> Apache Maven 3.0.4 (r1209000; 2011-12-01 09:49:38+0100)
> Maven home: /usr/local/Cellar/maven/current/libexec
> Java version: 1.6.0_29, vendor: Apple Inc.
> Java home: /Library/Java/JavaVirtualMachines/1.6.0_29-b11-402.jdk/Contents/Home
> Default locale: de_DE, platform encoding: MacRoman
> OS name: "mac os x", version: "10.7.2", arch: "x86_64", family: "mac"
> Reporter: Mirko Friedenhagen
> Assignee: Robert Scholte
> Fix For: fluido-1.1
>
> Attachments: documentation.patch, enable-external-links-for-sidebar-when-no-topbar.patch
>
>
> External links specified in {{//project/body/links}} of the {{site.xml}} are only rendered as dropdown menu when the topbar is enabled.
> When only the sidebar is enabled these links are missing completely. I have attached a patch against revision 1206640 of http://svn.apache.org/repos/asf/maven/skins/trunk/maven-fluido-skin, which will render these links as additional menu in the sidebar when {{topbarEnabled==false}} and {{sidebarEnabled==true}}.
> Example output might be found at http://mojo.codehaus.org/fluido-preview/ for the ckjm-maven-plugin.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MSKINS-15) With sidebar and no topbar external
links should be rendered as menu
Posted by "Mirko Friedenhagen (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MSKINS-15?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=284955#comment-284955 ]
Mirko Friedenhagen commented on MSKINS-15:
------------------------------------------
Hello Simone,
would you mind including this in version fluido-1.1?
Regards
Mirko
> With sidebar and no topbar external links should be rendered as menu
> --------------------------------------------------------------------
>
> Key: MSKINS-15
> URL: https://jira.codehaus.org/browse/MSKINS-15
> Project: Maven Skins
> Issue Type: Improvement
> Components: Fluido Skin
> Affects Versions: fluido-1.0, fluido-1.1
> Environment: {code}
> mvn --version
> Apache Maven 3.0.4 (r1209000; 2011-12-01 09:49:38+0100)
> Maven home: /usr/local/Cellar/maven/current/libexec
> Java version: 1.6.0_29, vendor: Apple Inc.
> Java home: /Library/Java/JavaVirtualMachines/1.6.0_29-b11-402.jdk/Contents/Home
> Default locale: de_DE, platform encoding: MacRoman
> OS name: "mac os x", version: "10.7.2", arch: "x86_64", family: "mac"
> {code}
> Reporter: Mirko Friedenhagen
> Attachments: enable-external-links-for-sidebar-when-no-topbar.patch
>
>
> External links specified in {{//project/body/links}} of the {{site.xml}} are only rendered as dropdown menu when the topbar is enabled.
> When only the sidebar is enabled these links are missing completely. I have attached a patch against revision 1206640 of http://svn.apache.org/repos/asf/maven/skins/trunk/maven-fluido-skin, which will render these links as additional menu in the sidebar when {{topbarEnabled==false}} and {{sidebarEnabled==true}}.
> Example output might be found at http://mojo.codehaus.org/fluido-preview/ for the ckjm-maven-plugin.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MSKINS-15) With sidebar and no topbar external
links should be rendered as menu
Posted by "Robert Scholte (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MSKINS-15?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Scholte updated MSKINS-15:
---------------------------------
Issue Type: Bug (was: Improvement)
> With sidebar and no topbar external links should be rendered as menu
> --------------------------------------------------------------------
>
> Key: MSKINS-15
> URL: https://jira.codehaus.org/browse/MSKINS-15
> Project: Maven Skins
> Issue Type: Bug
> Components: Fluido Skin
> Affects Versions: fluido-1.0, fluido-1.1
> Environment: mvn --version
> Apache Maven 3.0.4 (r1209000; 2011-12-01 09:49:38+0100)
> Maven home: /usr/local/Cellar/maven/current/libexec
> Java version: 1.6.0_29, vendor: Apple Inc.
> Java home: /Library/Java/JavaVirtualMachines/1.6.0_29-b11-402.jdk/Contents/Home
> Default locale: de_DE, platform encoding: MacRoman
> OS name: "mac os x", version: "10.7.2", arch: "x86_64", family: "mac"
> Reporter: Mirko Friedenhagen
> Assignee: Robert Scholte
> Fix For: fluido-1.1
>
> Attachments: documentation.patch, enable-external-links-for-sidebar-when-no-topbar.patch
>
>
> External links specified in {{//project/body/links}} of the {{site.xml}} are only rendered as dropdown menu when the topbar is enabled.
> When only the sidebar is enabled these links are missing completely. I have attached a patch against revision 1206640 of http://svn.apache.org/repos/asf/maven/skins/trunk/maven-fluido-skin, which will render these links as additional menu in the sidebar when {{topbarEnabled==false}} and {{sidebarEnabled==true}}.
> Example output might be found at http://mojo.codehaus.org/fluido-preview/ for the ckjm-maven-plugin.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MSKINS-15) With sidebar and no topbar external
links should be rendered as menu
Posted by "Mirko Friedenhagen (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MSKINS-15?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mirko Friedenhagen updated MSKINS-15:
-------------------------------------
Attachment: documentation.patch
At least we should describe what happends: I attach a patch against r1211638, which will update the documentation accordingly.
> With sidebar and no topbar external links should be rendered as menu
> --------------------------------------------------------------------
>
> Key: MSKINS-15
> URL: https://jira.codehaus.org/browse/MSKINS-15
> Project: Maven Skins
> Issue Type: Improvement
> Components: Fluido Skin
> Affects Versions: fluido-1.0, fluido-1.1
> Environment: {code}
> mvn --version
> Apache Maven 3.0.4 (r1209000; 2011-12-01 09:49:38+0100)
> Maven home: /usr/local/Cellar/maven/current/libexec
> Java version: 1.6.0_29, vendor: Apple Inc.
> Java home: /Library/Java/JavaVirtualMachines/1.6.0_29-b11-402.jdk/Contents/Home
> Default locale: de_DE, platform encoding: MacRoman
> OS name: "mac os x", version: "10.7.2", arch: "x86_64", family: "mac"
> {code}
> Reporter: Mirko Friedenhagen
> Assignee: Robert Scholte
> Fix For: fluido-1.1
>
> Attachments: documentation.patch, enable-external-links-for-sidebar-when-no-topbar.patch
>
>
> External links specified in {{//project/body/links}} of the {{site.xml}} are only rendered as dropdown menu when the topbar is enabled.
> When only the sidebar is enabled these links are missing completely. I have attached a patch against revision 1206640 of http://svn.apache.org/repos/asf/maven/skins/trunk/maven-fluido-skin, which will render these links as additional menu in the sidebar when {{topbarEnabled==false}} and {{sidebarEnabled==true}}.
> Example output might be found at http://mojo.codehaus.org/fluido-preview/ for the ckjm-maven-plugin.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira