You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Andrew Gaul <no...@github.com> on 2014/03/05 01:31:23 UTC
[jclouds-site] Modernize BlobStore examples (#59)
Use ByteSource payloads, call contentMD5 instead of calculateMD5, and
correct contentType calls.
You can merge this Pull Request by running:
git pull https://github.com/maginatics/jclouds-site modernize-blobstore-examples
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds-site/pull/59
-- Commit Summary --
* Modernize BlobStore examples
-- File Changes --
M _layouts/home.html (3)
M start/blobstore.md (25)
-- Patch Links --
https://github.com/jclouds/jclouds-site/pull/59.patch
https://github.com/jclouds/jclouds-site/pull/59.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/59
Re: [jclouds-site] Modernize BlobStore examples (#59)
Posted by Andrew Gaul <no...@github.com>.
> @@ -96,8 +96,9 @@ <h3 class="panel-title">BlobStore</h3>
>
> blobStore.createContainerInLocation(location, "mycontainer");
>
> +ByteSource payload = ByteSource.wrap("blob-content".getBytes(Charsets.UTF_8));
Done.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/59/files#r10588847
Re: [jclouds-site] Modernize BlobStore examples (#59)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-site-pull-requests #203](https://jclouds.ci.cloudbees.com/job/jclouds-site-pull-requests/203/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/59#issuecomment-36697424
Re: [jclouds-site] Modernize BlobStore examples (#59)
Posted by jclouds-commentator <no...@github.com>.
Go to http://50922bbcc0b370760eeb-c5161db033c907f2a461fa4544af29fb.r55.cf1.rackcdn.com/ to review your changes.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/59#issuecomment-37613542
Re: [jclouds-site] Modernize BlobStore examples (#59)
Posted by Andrew Phillips <no...@github.com>.
> @@ -96,8 +96,9 @@ <h3 class="panel-title">BlobStore</h3>
>
> blobStore.createContainerInLocation(location, "mycontainer");
>
> +ByteSource payload = ByteSource.wrap("blob-content".getBytes(Charsets.UTF_8));
Would it make sense to break this line somewhere? It's now the longest line in the example:
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/59/files#r10297301
Re: [jclouds-site] Modernize BlobStore examples (#59)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-site-pull-requests #217](https://jclouds.ci.cloudbees.com/job/jclouds-site-pull-requests/217/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/59#issuecomment-37612397
Re: [jclouds-site] Modernize BlobStore examples (#59)
Posted by Andrew Phillips <no...@github.com>.
> Blob blob = context.getBlobStore().blobBuilder("sushi.jpg")
> - .payload(new File("sushi.jpg"))// or byte[]. InputStream, etc.
[minor] Space before `//` and comma after `byte[]`?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/59/files#r10297226
Re: [jclouds-site] Modernize BlobStore examples (#59)
Posted by Andrew Gaul <no...@github.com>.
Pushed to master and deployed.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/59#issuecomment-37999805
Re: [jclouds-site] Modernize BlobStore examples (#59)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-site-pull-requests #218](https://jclouds.ci.cloudbees.com/job/jclouds-site-pull-requests/218/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/59#issuecomment-37613445
Re: [jclouds-site] Modernize BlobStore examples (#59)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-site-pull-requests #216](https://jclouds.ci.cloudbees.com/job/jclouds-site-pull-requests/216/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/59#issuecomment-37593232
Re: [jclouds-site] Modernize BlobStore examples (#59)
Posted by Andrew Phillips <no...@github.com>.
Thanks!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/59#issuecomment-38003514
Re: [jclouds-site] Modernize BlobStore examples (#59)
Posted by Andrew Phillips <no...@github.com>.
One minor comment, otherwise +1 - looks good to me. Thanks, @andrewgaul!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/59#issuecomment-36737251
Re: [jclouds-site] Modernize BlobStore examples (#59)
Posted by jclouds-commentator <no...@github.com>.
Go to http://2652f14e5456c7d8a584-84feae4228b9ba60f1e3b03619b50a08.r0.cf1.rackcdn.com/ to review your changes.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/59#issuecomment-37612482
Re: [jclouds-site] Modernize BlobStore examples (#59)
Posted by Andrew Gaul <no...@github.com>.
Closed #59.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/59