You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Bernd Mathiske <be...@mesosphere.io> on 2015/08/05 11:32:58 UTC

Review Request 37123: Fixed markdown rendering in C++ style guide.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37123/
-----------------------------------------------------------

Review request for mesos, Anand Mazumdar, haosdent huang, and Joerg Schad.


Bugs: MESOS-3207
    https://issues.apache.org/jira/browse/MESOS-3207


Repository: mesos


Description
-------

Fixed markdown rendering in C++ style guide.


Diffs
-----

  docs/mesos-c++-style-guide.md 9dca331400bf9eb522295f9261cbb349be6b533b 

Diff: https://reviews.apache.org/r/37123/diff/


Testing
-------


Thanks,

Bernd Mathiske


Re: Review Request 37123: Fixed markdown rendering in C++ style guide.

Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37123/#review94212
-----------------------------------------------------------

Ship it!


Ship It!

- haosdent huang


On Aug. 5, 2015, 9:35 a.m., Bernd Mathiske wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37123/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2015, 9:35 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, haosdent huang, and Joerg Schad.
> 
> 
> Bugs: MESOS-3207
>     https://issues.apache.org/jira/browse/MESOS-3207
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed markdown rendering in C++ style guide.
> 
> 
> Diffs
> -----
> 
>   docs/mesos-c++-style-guide.md 9dca331400bf9eb522295f9261cbb349be6b533b 
> 
> Diff: https://reviews.apache.org/r/37123/diff/
> 
> 
> Testing
> -------
> 
> Built the web site, patched the md file in question, ran `rake dev`, looked at http://localhost:4567/documentation/latest/mesos-c++-style-guide/.
> 
> 
> Thanks,
> 
> Bernd Mathiske
> 
>


Re: Review Request 37123: Fixed markdown rendering in C++ style guide.

Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37123/#review94216
-----------------------------------------------------------

Ship it!


Ship It!

- Joerg Schad


On Aug. 5, 2015, 9:35 a.m., Bernd Mathiske wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37123/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2015, 9:35 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, haosdent huang, and Joerg Schad.
> 
> 
> Bugs: MESOS-3207
>     https://issues.apache.org/jira/browse/MESOS-3207
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed markdown rendering in C++ style guide.
> 
> 
> Diffs
> -----
> 
>   docs/mesos-c++-style-guide.md 9dca331400bf9eb522295f9261cbb349be6b533b 
> 
> Diff: https://reviews.apache.org/r/37123/diff/
> 
> 
> Testing
> -------
> 
> Built the web site, patched the md file in question, ran `rake dev`, looked at http://localhost:4567/documentation/latest/mesos-c++-style-guide/.
> 
> 
> Thanks,
> 
> Bernd Mathiske
> 
>


Re: Review Request 37123: Fixed markdown rendering in C++ style guide.

Posted by Bernd Mathiske <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37123/
-----------------------------------------------------------

(Updated Aug. 5, 2015, 2:35 a.m.)


Review request for mesos, Anand Mazumdar, haosdent huang, and Joerg Schad.


Changes
-------

Tested.


Bugs: MESOS-3207
    https://issues.apache.org/jira/browse/MESOS-3207


Repository: mesos


Description
-------

Fixed markdown rendering in C++ style guide.


Diffs
-----

  docs/mesos-c++-style-guide.md 9dca331400bf9eb522295f9261cbb349be6b533b 

Diff: https://reviews.apache.org/r/37123/diff/


Testing (updated)
-------

Built the web site, patched the md file in question, ran `rake dev`, looked at http://localhost:4567/documentation/latest/mesos-c++-style-guide/.


Thanks,

Bernd Mathiske