[GitHub] [spark] heyihong commented on pull request #41743: [SPARK-42554][CONNECT] Implement GRPC exceptions interception for conversion

["heyihong (via GitHub)" <gi...@apache.org>]

heyihong commented on PR #41743:
URL: https://github.com/apache/spark/pull/41743#issuecomment-1620795530

   > Followup: I noticed that ArtifactManager uses GRPC stubs directly, and it also needs the non-blocking stub. Do we need error conversion for `addArtifacts` as well? Even if not, if we want to make this generic for adding similar wrappers, do we want to add a CustomSparkConnectNonBlockingStub as well (that hopefully could reuse GrpcExceptionConverter? Should functions be added to SparkConnectClient to be used by ArtifactManager instead of it using stubs directly?
   > 
   > cc also @dillitz
   
   Yes, that's a good point. It would be nice to have similar wrappers for both blocking and non-blocking stubs of ArtifactManager.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org