[jira] Commented: (SHINDIG-440) Simplify Guice Configuration

["Cassie Doll (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SHINDIG-440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12612569#action_12612569 ] 

Cassie Doll commented on SHINDIG-440:
-------------------------------------

This looks fine to me - but you have a System.out you probably didn't intend for and your annotations are sometimes right on top of the class declaration and sometimes there is a line separating them. If you could make that consistent, that would be great. 

> Simplify Guice Configuration
> ----------------------------
>
>                 Key: SHINDIG-440
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-440
>             Project: Shindig
>          Issue Type: Improvement
>          Components: Common Components (Java)
>            Reporter: Paul Lindner
>         Attachments: simpleguice.diff
>
>
> Guice modules can be a pain, since they don't allow for overriding specific bindings.
> I propose that we annotate each interface with @ImplementedBy for the built-in default.
> This will allow easier customization of Shindig -- one just needs to bind the specific implementation classes, and one does not have to cut-and-paste module binding code.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.