[GitHub] [airflow] ashb commented on a change in pull request #5913: [AIRFLOW-5073] Change SQLSensor to treat NULL failure

[GitBox <gi...@apache.org>]

ashb commented on a change in pull request #5913: [AIRFLOW-5073] Change SQLSensor to treat NULL failure
URL: https://github.com/apache/airflow/pull/5913#discussion_r334649773
 
 

 ##########
 File path: airflow/sensors/sql_sensor.py
 ##########
 @@ -102,6 +98,4 @@ def poke(self, context):
                 return self.success(first_cell)
             else:
                 raise AirflowException("self.success is present, but not callable -> {}".format(self.success))
-        if self.allow_null:
-            return str(first_cell) not in ('0', '')
         return str(first_cell) not in ('0', '', 'None')
 
 Review comment:
   There's no way to change the merged PR. You'd have to create a new PR with that change please.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services