You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2022/01/27 10:55:00 UTC
[GitHub] [incubator-mxnet] anko-intel opened a new pull request #20854: [BUGFIX] Remove compilation warning
anko-intel opened a new pull request #20854:
URL: https://github.com/apache/incubator-mxnet/pull/20854
## Description ##
It gets rid of compiltation warning:
'float' changes value from 2147483647 to 2147483648
for -Wimplicit-const-int-float-conversion flag
It fixes https://github.com/apache/incubator-mxnet/issues/20833
## Checklist ##
### Essentials ###
- [ ] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
- [ ] Changes are complete (i.e. I finished coding on this PR)
- [ ] All changes have test coverage
- [ ] Code is well-documented
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20854: [BUGFIX] Remove compilation warning
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20854:
URL: https://github.com/apache/incubator-mxnet/pull/20854#issuecomment-1023957953
Jenkins CI successfully triggered : [unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bgawrych merged pull request #20854: [BUGFIX] Remove compilation warning
Posted by GitBox <gi...@apache.org>.
bgawrych merged pull request #20854:
URL: https://github.com/apache/incubator-mxnet/pull/20854
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20854: [BUGFIX] Remove compilation warning
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20854:
URL: https://github.com/apache/incubator-mxnet/pull/20854#issuecomment-1023085181
Hey @anko-intel , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [edge, centos-cpu, unix-gpu, windows-cpu, miscellaneous, sanity, clang, unix-cpu, windows-gpu, centos-gpu, website]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bartekkuncer commented on a change in pull request #20854: [BUGFIX] Remove compilation warning
Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on a change in pull request #20854:
URL: https://github.com/apache/incubator-mxnet/pull/20854#discussion_r793679497
##########
File path: src/operator/quantization/mkldnn/mkldnn_quantized_elemwise_add.cc
##########
@@ -135,7 +135,8 @@ static void MKLDNNQuantizedElemwiseAddForward(const nnvm::NodeAttrs& attrs,
output_data_range = kUint8Range;
output_data_type = mkldnn::memory::data_type::u8;
} else {
- output_data_range = kInt32Range;
+ // The impact of rounding in line below is negligible.
Review comment:
Why not just remove this else as the proper values will be already set during initialization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bartekkuncer commented on a change in pull request #20854: [BUGFIX] Remove compilation warning
Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on a change in pull request #20854:
URL: https://github.com/apache/incubator-mxnet/pull/20854#discussion_r793679497
##########
File path: src/operator/quantization/mkldnn/mkldnn_quantized_elemwise_add.cc
##########
@@ -135,7 +135,8 @@ static void MKLDNNQuantizedElemwiseAddForward(const nnvm::NodeAttrs& attrs,
output_data_range = kUint8Range;
output_data_type = mkldnn::memory::data_type::u8;
} else {
- output_data_range = kInt32Range;
+ // The impact of rounding in line below is negligible.
Review comment:
Why not just remove this else as the proper values are already being set during initialization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] anko-intel commented on pull request #20854: [BUGFIX] Remove compilation warning
Posted by GitBox <gi...@apache.org>.
anko-intel commented on pull request #20854:
URL: https://github.com/apache/incubator-mxnet/pull/20854#issuecomment-1023957907
@mxnet-bot run ci [unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] anko-intel commented on a change in pull request #20854: [BUGFIX] Remove compilation warning
Posted by GitBox <gi...@apache.org>.
anko-intel commented on a change in pull request #20854:
URL: https://github.com/apache/incubator-mxnet/pull/20854#discussion_r793755181
##########
File path: src/operator/quantization/mkldnn/mkldnn_quantized_elemwise_add.cc
##########
@@ -135,7 +135,8 @@ static void MKLDNNQuantizedElemwiseAddForward(const nnvm::NodeAttrs& attrs,
output_data_range = kUint8Range;
output_data_type = mkldnn::memory::data_type::u8;
} else {
- output_data_range = kInt32Range;
+ // The impact of rounding in line below is negligible.
Review comment:
Good point! Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org