You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/10/07 11:19:10 UTC
[GitHub] [skywalking-client-js] michaelzangl opened a new pull request, #96: Mention that UI cannot display an empty page path
michaelzangl opened a new pull request, #96:
URL: https://github.com/apache/skywalking-client-js/pull/96
Seems to "not be a bug", but should at least be documented, that sending an empty pagePath may crash the UI when viewing the traces later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-client-js] michaelzangl commented on pull request #96: Mention that UI cannot display an empty page path
Posted by GitBox <gi...@apache.org>.
michaelzangl commented on PR #96:
URL: https://github.com/apache/skywalking-client-js/pull/96#issuecomment-1271472699
Feel free to add that to the documentation, too.
I just want to document that sending an empty string there would crash the UI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-client-js] wu-sheng closed pull request #96: Mention that UI cannot display an empty page path
Posted by GitBox <gi...@apache.org>.
wu-sheng closed pull request #96: Mention that UI cannot display an empty page path
URL: https://github.com/apache/skywalking-client-js/pull/96
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-client-js] wu-sheng commented on pull request #96: Mention that UI cannot display an empty page path
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #96:
URL: https://github.com/apache/skywalking-client-js/pull/96#issuecomment-1271471731
This is not what I mean. The endpoint could be null from design perspective, which mean no endpoint relative metrics should be generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-client-js] wu-sheng commented on pull request #96: Mention that UI cannot display an empty page path
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #96:
URL: https://github.com/apache/skywalking-client-js/pull/96#issuecomment-1271478282
I have replied on the original issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org