You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by mtaylor <gi...@git.apache.org> on 2015/11/05 13:15:33 UTC
[GitHub] activemq-artemis pull request: Use .equals for string compare in L...
GitHub user mtaylor opened a pull request:
https://github.com/apache/activemq-artemis/pull/238
Use .equals for string compare in LDAPLoginModule
String#equals implementations generally do a object reference == before anything else. So there is no performance gain in doing == Strings in our codebase. See: http://hg.openjdk.java.net/jdk7/jdk7/jdk/file/9b8c96f96a0f/src/share/classes/java/lang/String.java#l1013
This patch replaces String== with .equals, which removes compile warnings and is less brittle.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mtaylor/activemq-artemis StringCompareInLDAPModule
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/238.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #238
----
commit 1c07536435df91e1e605da1f21d4ca6fc8f808ca
Author: Martyn Taylor <mt...@redhat.com>
Date: 2015-11-05T12:05:08Z
Use .equals for string compare in LDAPLoginModule
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Use .equals for string compare in L...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/238
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Build issues
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/238
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Build issues
Posted by andytaylor <gi...@git.apache.org>.
Github user andytaylor commented on the pull request:
https://github.com/apache/activemq-artemis/pull/238#issuecomment-100874753
i'll get this merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---