You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Robert Munteanu (Jira)" <ji...@apache.org> on 2023/04/19 15:55:00 UTC
[jira] [Resolved] (SLING-11777) CPConverter - Sling Initial Content - default nodetype - filevault upgrade
[ https://issues.apache.org/jira/browse/SLING-11777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Munteanu resolved SLING-11777.
-------------------------------------
Fix Version/s: (was: Content-Package to Feature Model Converter 1.3.2)
Assignee: (was: Niek Raaijmakers)
Resolution: Abandoned
[~Sc0rpic0m] closed the PR with the following comment
{quote}After internal discussions, we decided to go for the original approach of using repoinit statement (this time making sure only 1 per path gets outputted with the proper primary type) and leaving the filters untouched. Closing PR for now.{quote}
I assume that this issue is no longer needed.
> CPConverter - Sling Initial Content - default nodetype - filevault upgrade
> --------------------------------------------------------------------------
>
> Key: SLING-11777
> URL: https://issues.apache.org/jira/browse/SLING-11777
> Project: Sling
> Issue Type: Improvement
> Components: Content-Package to Feature Model Converter
> Reporter: Niek Raaijmakers
> Priority: Blocker
>
> To solve a problem with default nodetype being nt:folder while it should be sling:Folder for sling initial content parsed by the cpconverter, we implemented a workaround back in the day using create path statements for each folder. The subsequent package installation with filters containing mode=update, would overwrite the primaryType where it was defined in the source package. This worked in filevault 3.4.0.
>
> However with filevault 3.6.0+ the primaryType is no longer updated with the filter update, so we need a new approach / workaround.
>
> The new approach is to provide .content.xml files for all the parents (up to /jcr:root/apps/parent, but not jcr:root/apps) in the package. Then we use the replace filter instead ( should correspond with the original sling initial content behaviour, see [source code|https://github.com/apache/sling-org-apache-sling-jcr-contentloader/blob/master/src/main/java/org/apache/sling/jcr/contentloader/internal/JcrXmlImporter.java#L67])
> We also need to update the merge to merge_properties filter, as merge is now deprecated.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)