You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/26 06:46:55 UTC
[GitHub] [spark] HyukjinKwon opened a new pull request #27703:
[SPARK-30798][SQL][TESTS][FOLLOW-UP] Set the configuration against the
current session explicitly in HiveShowCreateTableSuite
HyukjinKwon opened a new pull request #27703: [SPARK-30798][SQL][TESTS][FOLLOW-UP] Set the configuration against the current session explicitly in HiveShowCreateTableSuite
URL: https://github.com/apache/spark/pull/27703
### What changes were proposed in this pull request?
After https://github.com/apache/spark/pull/27387, the tests below fail specifically in one job https://amplab.cs.berkeley.edu/jenkins/job/spark-master-test-sbt-hadoop-2.7-hive-2.3/ in Jenkins
```
org.apache.spark.sql.hive.HiveShowCreateTableSuite.simple hive table
org.apache.spark.sql.hive.HiveShowCreateTableSuite.simple external hive table
org.apache.spark.sql.hive.HiveShowCreateTableSuite.hive bucketing is supported
```
The profile is same as PR builder but seems it fails specifically in this machine. See https://amplab.cs.berkeley.edu/jenkins/job/spark-master-test-sbt-hadoop-2.7-hive-2.3/278/ as an example. Seems the legacy configuration `spark.sql.legacy.createHiveTableByDefault.enabled` is not being set due to the inconsistency between `SQLConf.get` and the active Spark session described in the https://github.com/apache/spark/pull/27387.
This PR proposes to explicitly set the configuration against the session used instead of `SQLConf.get`.
### Why are the changes needed?
To make `spark-master-test-sbt-hadoop-2.7-hive-2.3` job pass.
### Does this PR introduce any user-facing change?
No.
### How was this patch tested?
Cannot reproduce in my local. Presumably it cannot be reproduced in the PR builder. We should see if the tests pass after this PR is merged
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27703:
[SPARK-30798][SQL][TESTS][FOLLOW-UP] Set the configuration against the
current session explicitly in HiveShowCreateTableSuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27703: [SPARK-30798][SQL][TESTS][FOLLOW-UP] Set the configuration against the current session explicitly in HiveShowCreateTableSuite
URL: https://github.com/apache/spark/pull/27703#issuecomment-591383876
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27703:
[SPARK-30798][SQL][TESTS][FOLLOW-UP] Set the configuration against the
current session explicitly in HiveShowCreateTableSuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27703: [SPARK-30798][SQL][TESTS][FOLLOW-UP] Set the configuration against the current session explicitly in HiveShowCreateTableSuite
URL: https://github.com/apache/spark/pull/27703#issuecomment-591292536
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27703:
[SPARK-30798][SQL][TESTS][FOLLOW-UP] Set the configuration against the
current session explicitly in HiveShowCreateTableSuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27703: [SPARK-30798][SQL][TESTS][FOLLOW-UP] Set the configuration against the current session explicitly in HiveShowCreateTableSuite
URL: https://github.com/apache/spark/pull/27703#issuecomment-591292549
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118949/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #27703:
[SPARK-30798][SQL][TESTS][FOLLOW-UP] Set the configuration against the
current session explicitly in HiveShowCreateTableSuite
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #27703: [SPARK-30798][SQL][TESTS][FOLLOW-UP] Set the configuration against the current session explicitly in HiveShowCreateTableSuite
URL: https://github.com/apache/spark/pull/27703#issuecomment-591386599
Thanks guys.
Merged to master and branch-3.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27703:
[SPARK-30798][SQL][TESTS][FOLLOW-UP] Set the configuration against the
current session explicitly in HiveShowCreateTableSuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27703: [SPARK-30798][SQL][TESTS][FOLLOW-UP] Set the configuration against the current session explicitly in HiveShowCreateTableSuite
URL: https://github.com/apache/spark/pull/27703#issuecomment-591292549
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118949/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #27703:
[SPARK-30798][SQL][TESTS][FOLLOW-UP] Set the configuration against the
current session explicitly in HiveShowCreateTableSuite
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #27703: [SPARK-30798][SQL][TESTS][FOLLOW-UP] Set the configuration against the current session explicitly in HiveShowCreateTableSuite
URL: https://github.com/apache/spark/pull/27703
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27703:
[SPARK-30798][SQL][TESTS][FOLLOW-UP] Set the configuration against the
current session explicitly in HiveShowCreateTableSuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27703: [SPARK-30798][SQL][TESTS][FOLLOW-UP] Set the configuration against the current session explicitly in HiveShowCreateTableSuite
URL: https://github.com/apache/spark/pull/27703#issuecomment-591310869
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27703:
[SPARK-30798][SQL][TESTS][FOLLOW-UP] Set the configuration against the
current session explicitly in HiveShowCreateTableSuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27703: [SPARK-30798][SQL][TESTS][FOLLOW-UP] Set the configuration against the current session explicitly in HiveShowCreateTableSuite
URL: https://github.com/apache/spark/pull/27703#issuecomment-591310881
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23711/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27703:
[SPARK-30798][SQL][TESTS][FOLLOW-UP] Set the configuration against the
current session explicitly in HiveShowCreateTableSuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27703: [SPARK-30798][SQL][TESTS][FOLLOW-UP] Set the configuration against the current session explicitly in HiveShowCreateTableSuite
URL: https://github.com/apache/spark/pull/27703#issuecomment-591268165
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23698/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27703:
[SPARK-30798][SQL][TESTS][FOLLOW-UP] Set the configuration against the
current session explicitly in HiveShowCreateTableSuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27703: [SPARK-30798][SQL][TESTS][FOLLOW-UP] Set the configuration against the current session explicitly in HiveShowCreateTableSuite
URL: https://github.com/apache/spark/pull/27703#issuecomment-591310881
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23711/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27703:
[SPARK-30798][SQL][TESTS][FOLLOW-UP] Set the configuration against the
current session explicitly in HiveShowCreateTableSuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27703: [SPARK-30798][SQL][TESTS][FOLLOW-UP] Set the configuration against the current session explicitly in HiveShowCreateTableSuite
URL: https://github.com/apache/spark/pull/27703#issuecomment-591383883
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118962/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27703:
[SPARK-30798][SQL][TESTS][FOLLOW-UP] Set the configuration against the
current session explicitly in HiveShowCreateTableSuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27703: [SPARK-30798][SQL][TESTS][FOLLOW-UP] Set the configuration against the current session explicitly in HiveShowCreateTableSuite
URL: https://github.com/apache/spark/pull/27703#issuecomment-591268157
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27703:
[SPARK-30798][SQL][TESTS][FOLLOW-UP] Set the configuration against the
current session explicitly in HiveShowCreateTableSuite
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27703: [SPARK-30798][SQL][TESTS][FOLLOW-UP] Set the configuration against the current session explicitly in HiveShowCreateTableSuite
URL: https://github.com/apache/spark/pull/27703#issuecomment-591310395
**[Test build #118962 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118962/testReport)** for PR 27703 at commit [`412062d`](https://github.com/apache/spark/commit/412062d37274251c62ab82a379f1208bfdf28a53).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27703:
[SPARK-30798][SQL][TESTS][FOLLOW-UP] Set the configuration against the
current session explicitly in HiveShowCreateTableSuite
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27703: [SPARK-30798][SQL][TESTS][FOLLOW-UP] Set the configuration against the current session explicitly in HiveShowCreateTableSuite
URL: https://github.com/apache/spark/pull/27703#issuecomment-591292382
**[Test build #118949 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118949/testReport)** for PR 27703 at commit [`412062d`](https://github.com/apache/spark/commit/412062d37274251c62ab82a379f1208bfdf28a53).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27703:
[SPARK-30798][SQL][TESTS][FOLLOW-UP] Set the configuration against the
current session explicitly in HiveShowCreateTableSuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27703: [SPARK-30798][SQL][TESTS][FOLLOW-UP] Set the configuration against the current session explicitly in HiveShowCreateTableSuite
URL: https://github.com/apache/spark/pull/27703#issuecomment-591383876
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #27703:
[SPARK-30798][SQL][TESTS][FOLLOW-UP] Set the configuration against the
current session explicitly in HiveShowCreateTableSuite
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #27703: [SPARK-30798][SQL][TESTS][FOLLOW-UP] Set the configuration against the current session explicitly in HiveShowCreateTableSuite
URL: https://github.com/apache/spark/pull/27703#issuecomment-591308360
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27703:
[SPARK-30798][SQL][TESTS][FOLLOW-UP] Set the configuration against the
current session explicitly in HiveShowCreateTableSuite
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27703: [SPARK-30798][SQL][TESTS][FOLLOW-UP] Set the configuration against the current session explicitly in HiveShowCreateTableSuite
URL: https://github.com/apache/spark/pull/27703#issuecomment-591383279
**[Test build #118962 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118962/testReport)** for PR 27703 at commit [`412062d`](https://github.com/apache/spark/commit/412062d37274251c62ab82a379f1208bfdf28a53).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27703:
[SPARK-30798][SQL][TESTS][FOLLOW-UP] Set the configuration against the
current session explicitly in HiveShowCreateTableSuite
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27703: [SPARK-30798][SQL][TESTS][FOLLOW-UP] Set the configuration against the current session explicitly in HiveShowCreateTableSuite
URL: https://github.com/apache/spark/pull/27703#issuecomment-591269914
**[Test build #118949 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118949/testReport)** for PR 27703 at commit [`412062d`](https://github.com/apache/spark/commit/412062d37274251c62ab82a379f1208bfdf28a53).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27703:
[SPARK-30798][SQL][TESTS][FOLLOW-UP] Set the configuration against the
current session explicitly in HiveShowCreateTableSuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27703: [SPARK-30798][SQL][TESTS][FOLLOW-UP] Set the configuration against the current session explicitly in HiveShowCreateTableSuite
URL: https://github.com/apache/spark/pull/27703#issuecomment-591383883
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118962/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27703:
[SPARK-30798][SQL][TESTS][FOLLOW-UP] Set the configuration against the
current session explicitly in HiveShowCreateTableSuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27703: [SPARK-30798][SQL][TESTS][FOLLOW-UP] Set the configuration against the current session explicitly in HiveShowCreateTableSuite
URL: https://github.com/apache/spark/pull/27703#issuecomment-591268157
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27703:
[SPARK-30798][SQL][TESTS][FOLLOW-UP] Set the configuration against the
current session explicitly in HiveShowCreateTableSuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27703: [SPARK-30798][SQL][TESTS][FOLLOW-UP] Set the configuration against the current session explicitly in HiveShowCreateTableSuite
URL: https://github.com/apache/spark/pull/27703#issuecomment-591310869
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27703:
[SPARK-30798][SQL][TESTS][FOLLOW-UP] Set the configuration against the
current session explicitly in HiveShowCreateTableSuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27703: [SPARK-30798][SQL][TESTS][FOLLOW-UP] Set the configuration against the current session explicitly in HiveShowCreateTableSuite
URL: https://github.com/apache/spark/pull/27703#issuecomment-591292536
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27703:
[SPARK-30798][SQL][TESTS][FOLLOW-UP] Set the configuration against the
current session explicitly in HiveShowCreateTableSuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27703: [SPARK-30798][SQL][TESTS][FOLLOW-UP] Set the configuration against the current session explicitly in HiveShowCreateTableSuite
URL: https://github.com/apache/spark/pull/27703#issuecomment-591268165
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23698/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] hvanhovell commented on a change in pull request #27703:
[SPARK-30798][SQL][TESTS][FOLLOW-UP] Set the configuration against the
current session explicitly in HiveShowCreateTableSuite
Posted by GitBox <gi...@apache.org>.
hvanhovell commented on a change in pull request #27703: [SPARK-30798][SQL][TESTS][FOLLOW-UP] Set the configuration against the current session explicitly in HiveShowCreateTableSuite
URL: https://github.com/apache/spark/pull/27703#discussion_r384360661
##########
File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveShowCreateTableSuite.scala
##########
@@ -30,12 +30,13 @@ class HiveShowCreateTableSuite extends ShowCreateTableSuite with TestHiveSinglet
protected override def beforeAll(): Unit = {
super.beforeAll()
origCreateHiveTableConfig =
- SQLConf.get.getConf(SQLConf.LEGACY_CREATE_HIVE_TABLE_BY_DEFAULT_ENABLED)
- SQLConf.get.setConf(SQLConf.LEGACY_CREATE_HIVE_TABLE_BY_DEFAULT_ENABLED, true)
+ spark.conf.get(SQLConf.LEGACY_CREATE_HIVE_TABLE_BY_DEFAULT_ENABLED)
Review comment:
Slightly tangential remark, in this case we could also clone the session. That way we don't have to undo setting this flag in `afterAll()`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27703:
[SPARK-30798][SQL][TESTS][FOLLOW-UP] Set the configuration against the
current session explicitly in HiveShowCreateTableSuite
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27703: [SPARK-30798][SQL][TESTS][FOLLOW-UP] Set the configuration against the current session explicitly in HiveShowCreateTableSuite
URL: https://github.com/apache/spark/pull/27703#issuecomment-591310395
**[Test build #118962 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118962/testReport)** for PR 27703 at commit [`412062d`](https://github.com/apache/spark/commit/412062d37274251c62ab82a379f1208bfdf28a53).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27703:
[SPARK-30798][SQL][TESTS][FOLLOW-UP] Set the configuration against the
current session explicitly in HiveShowCreateTableSuite
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27703: [SPARK-30798][SQL][TESTS][FOLLOW-UP] Set the configuration against the current session explicitly in HiveShowCreateTableSuite
URL: https://github.com/apache/spark/pull/27703#issuecomment-591269914
**[Test build #118949 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118949/testReport)** for PR 27703 at commit [`412062d`](https://github.com/apache/spark/commit/412062d37274251c62ab82a379f1208bfdf28a53).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org