You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Colin Ma <ju...@intel.com> on 2015/05/12 08:57:03 UTC
Review Request 34080: SENTRY-728: Update audit log for grant user to
role
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34080/
-----------------------------------------------------------
Review request for sentry, Dapeng Sun, shen guoquan, and Prasad Mujumdar.
Repository: sentry
Description
-------
Update audit log for grant user to role
Diffs
-----
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/JsonLogEntityFactory.java 90308f4
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/util/CommandUtil.java 9beef83
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/util/Constants.java 072a0e8
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/log/util/TestCommandUtil.java 0a2b0b2
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbDDLAuditLog.java 2cecdfd
Diff: https://reviews.apache.org/r/34080/diff/
Testing
-------
Thanks,
Colin Ma
Re: Review Request 34080: SENTRY-728: Update audit log for grant user
to role
Posted by Dapeng Sun <da...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34080/#review128320
-----------------------------------------------------------
Ship it!
Ship It!
- Dapeng Sun
On 四月 6, 2016, 10:48 p.m., Colin Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34080/
> -----------------------------------------------------------
>
> (Updated 四月 6, 2016, 10:48 p.m.)
>
>
> Review request for sentry, Dapeng Sun and Jerry Chen.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Update audit log for grant user to role
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/JsonLogEntityFactory.java c29b88e
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/util/CommandUtil.java d6aecd1
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/util/Constants.java b0a87ae
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/log/util/TestCommandUtil.java 8620f62
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbDDLAuditLog.java 3afd6b2
>
> Diff: https://reviews.apache.org/r/34080/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Colin Ma
>
>
Re: Review Request 34080: SENTRY-728: Update audit log for grant user
to role
Posted by Jerry Chen <ha...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34080/#review127549
-----------------------------------------------------------
LGTM
- Jerry Chen
On April 6, 2016, 2:48 p.m., Colin Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34080/
> -----------------------------------------------------------
>
> (Updated April 6, 2016, 2:48 p.m.)
>
>
> Review request for sentry, Dapeng Sun and Jerry Chen.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Update audit log for grant user to role
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/JsonLogEntityFactory.java c29b88e
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/util/CommandUtil.java d6aecd1
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/util/Constants.java b0a87ae
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/log/util/TestCommandUtil.java 8620f62
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbDDLAuditLog.java 3afd6b2
>
> Diff: https://reviews.apache.org/r/34080/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Colin Ma
>
>
Re: Review Request 34080: SENTRY-728: Update audit log for grant user
to role
Posted by Colin Ma <ju...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34080/
-----------------------------------------------------------
(Updated 四月 6, 2016, 2:48 p.m.)
Review request for sentry, Dapeng Sun and Jerry Chen.
Repository: sentry
Description
-------
Update audit log for grant user to role
Diffs (updated)
-----
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/JsonLogEntityFactory.java c29b88e
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/util/CommandUtil.java d6aecd1
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/util/Constants.java b0a87ae
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/log/util/TestCommandUtil.java 8620f62
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbDDLAuditLog.java 3afd6b2
Diff: https://reviews.apache.org/r/34080/diff/
Testing
-------
Thanks,
Colin Ma
Re: Review Request 34080: SENTRY-728: Update audit log for grant user
to role
Posted by Colin Ma <ju...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34080/
-----------------------------------------------------------
(Updated 四月 6, 2016, 5:20 a.m.)
Review request for sentry, Dapeng Sun, shen guoquan, and Prasad Mujumdar.
Changes
-------
Update patch
Repository: sentry
Description
-------
Update audit log for grant user to role
Diffs (updated)
-----
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/JsonLogEntityFactory.java c29b88e
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/util/CommandUtil.java d6aecd1
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/util/Constants.java b0a87ae
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/log/util/TestCommandUtil.java 8620f62
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbDDLAuditLog.java 3afd6b2
Diff: https://reviews.apache.org/r/34080/diff/
Testing
-------
Thanks,
Colin Ma
Re: Review Request 34080: SENTRY-728: Update audit log for grant user
to role
Posted by Jerry Chen <ha...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34080/#review126509
-----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/util/Constants.java (line 85)
<https://reviews.apache.org/r/34080/#comment189514>
Can we follow the same format pattern to change line at the first parameter?
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/util/Constants.java (line 100)
<https://reviews.apache.org/r/34080/#comment189515>
The same format: new line at the first parameter to be consistent with the code in the same block.
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbDDLAuditLog.java (line 224)
<https://reviews.apache.org/r/34080/#comment189516>
Can this code block put after the group related code block?
It seems that we follow a pattern to add the code for user after the group. But this time is reverse?
- Jerry Chen
On May 12, 2015, 6:57 a.m., Colin Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34080/
> -----------------------------------------------------------
>
> (Updated May 12, 2015, 6:57 a.m.)
>
>
> Review request for sentry, Dapeng Sun, shen guoquan, and Prasad Mujumdar.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Update audit log for grant user to role
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/JsonLogEntityFactory.java 90308f4
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/util/CommandUtil.java 9beef83
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/util/Constants.java 072a0e8
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/log/util/TestCommandUtil.java 0a2b0b2
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbDDLAuditLog.java 2cecdfd
>
> Diff: https://reviews.apache.org/r/34080/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Colin Ma
>
>
Re: Review Request 34080: SENTRY-728: Update audit log for grant user
to role
Posted by Dapeng Sun <da...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34080/#review126533
-----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/util/CommandUtil.java (line 95)
<https://reviews.apache.org/r/34080/#comment189558>
Can we merge `createCmdForRoleDeleteUser` and `createCmdForRoleAddOrDeleteGroup` to one method?
Thank Colin, one minor comments left.
- Dapeng Sun
On 五月 12, 2015, 2:57 p.m., Colin Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34080/
> -----------------------------------------------------------
>
> (Updated 五月 12, 2015, 2:57 p.m.)
>
>
> Review request for sentry, Dapeng Sun, shen guoquan, and Prasad Mujumdar.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Update audit log for grant user to role
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/JsonLogEntityFactory.java 90308f4
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/util/CommandUtil.java 9beef83
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/util/Constants.java 072a0e8
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/log/util/TestCommandUtil.java 0a2b0b2
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbDDLAuditLog.java 2cecdfd
>
> Diff: https://reviews.apache.org/r/34080/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Colin Ma
>
>