You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by "hudi-bot (via GitHub)" <gi...@apache.org> on 2025/11/30 13:33:37 UTC

[I] Improve variable naming around time in incremental query logic [hudi]

hudi-bot opened a new issue, #17289:
URL: https://github.com/apache/hudi/issues/17289

   It can be confusing to use "Start" or "Time" without much context as we have the checkpoint to resume from and stop at for the incremental queries, and instant and completion time in the timeline.  So it would be good to do the following renaming and make the names consistent across the code base:
    * "beginCompletionTime": checkpoint to resume from
    * "endCompletionTime": checkpoint to stop at
    * "instantTime"/"commitTime": for instant time or start time of an instant on the timeline
    * "completionTime": completion time of an instant
   
   Do not use "startTime", "endTime", etc that can cause confusion.
   
    
   
   ## JIRA info
   
   - Link: https://issues.apache.org/jira/browse/HUDI-8373
   - Type: Sub-task
   - Parent: https://issues.apache.org/jira/browse/HUDI-9107
   - Fix version(s):
     - 1.1.0


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Improve variable naming around time in incremental query logic [hudi]

Posted by "rangareddy (via GitHub)" <gi...@apache.org>.

rangareddy commented on issue #17289:
URL: https://github.com/apache/hudi/issues/17289#issuecomment-5365815380

This issue was reviewed as part of the JIRA-migrated backlog triage (HUDI-8373).

**Findings: the substance of this has been achieved; only the exact word differs.**

The central requirement - *"Do not use startTime, endTime, etc that can cause confusion"* - is met in the file that matters. Searching `hudi-common/src/main/java/org/apache/hudi/common/table/read/IncrementalQueryAnalyzer.java` for `startTime` or `endTime` returns nothing.

What the codebase settled on is `startCompletionTime` / `endCompletionTime`:

- `IncrementalQueryAnalyzer.java` - 16 occurrences
- `CompletionTimeQueryView.java`, `versioning/v2/CompletionTimeQueryViewV2.java`
- `hudi-flink-datasource/hudi-flink/.../source/IncrementalInputSplits.java`

The ticket asked for `beginCompletionTime`, which has **zero** occurrences anywhere. And `instantTime` / `completionTime` for the timeline concepts are in use as requested.

So the ambiguity this ticket was filed to remove is gone; the difference is "start" versus "begin" as the prefix. That is a judgement call, not a defect. Recommend either closing this as substantively done, or narrowing it to a mechanical rename with a stated preference - and if the latter, it is worth doing repo-wide in one pass rather than piecemeal.

Keeping this open pending that call.

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org