[GitHub] [solr] HoustonPutman commented on a diff in pull request #1923: SOLR-16979: Randomize port number of Solr in BATS tests

["HoustonPutman (via GitHub)" <gi...@apache.org>]

HoustonPutman commented on code in PR #1923:
URL: https://github.com/apache/solr/pull/1923#discussion_r1325990016


##########
solr/packaging/build.gradle:
##########
@@ -250,11 +251,18 @@ task integrationTests(type: BatsTask) {
 
     // TODO - if quiet then don't tee
     standardOutput = new TeeOutputStream(System.out, new FileOutputStream("$integrationTestOutput/test-output.txt"))
-
+    println("Runnin BATS tests with Solr base port ${solrPort}")
   }
 
   environment SOLR_TIP: distDir.toString()
   environment SOLR_HOME: solrHome
+  environment SOLR_PID_DIR: solrHome
+  environment SOLR_PORT: solrPort
+  environment SOLR2_PORT: solrPort + 1
+  environment SOLR3_PORT: solrPort + 2
+  environment SOLR_PORT_8983: 8983
+  environment SOLR_PORT_7574: 7574

Review Comment:
   We do need a Solr 3. The new mTLS tests spin up a third node. They could restart the second node instead, so your choice there.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org