You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by xiaojian zhou <zh...@gmail.com> on 2016/03/05 02:55:46 UTC
Review Request 44412: specify logLevel in command line of geode for
running dunit test
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44412/
-----------------------------------------------------------
Review request for geode, anilkumar gingade and Dan Smith.
Bugs: geode-1052
https://issues.apache.org/jira/browse/geode-1052
Repository: geode
Description
-------
Need to tell the gradle of the commandline property. Then let gradle to tell the dunit test.
Diffs
-----
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/DistributedTestCase.java 65224e8
gradle/test.gradle d8af4ba
Diff: https://reviews.apache.org/r/44412/diff/
Testing
-------
precheckin and some dunit tests
Thanks,
xiaojian zhou
Re: Review Request 44412: specify logLevel in command line of geode
for running dunit test
Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44412/#review122574
-----------------------------------------------------------
Ship it!
Looks good! I'm not sure if the change to DistributedTestCase is needed, there is already code in DUnitLauncher that is reading a logLevel system property. You could test it without your DistributedTestCase change and see if it works.
public static final String LOG_LEVEL = System.getProperty("logLevel", "info");
- Dan Smith
On March 5, 2016, 1:55 a.m., xiaojian zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44412/
> -----------------------------------------------------------
>
> (Updated March 5, 2016, 1:55 a.m.)
>
>
> Review request for geode, anilkumar gingade and Dan Smith.
>
>
> Bugs: geode-1052
> https://issues.apache.org/jira/browse/geode-1052
>
>
> Repository: geode
>
>
> Description
> -------
>
> Need to tell the gradle of the commandline property. Then let gradle to tell the dunit test.
>
>
> Diffs
> -----
>
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/DistributedTestCase.java 65224e8
> gradle/test.gradle d8af4ba
>
> Diff: https://reviews.apache.org/r/44412/diff/
>
>
> Testing
> -------
>
> precheckin and some dunit tests
>
>
> Thanks,
>
> xiaojian zhou
>
>