You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2015/08/25 01:00:00 UTC
Review Request 37734: Used recursive bind mounts for volumes.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37734/
-----------------------------------------------------------
Review request for mesos, Timothy Chen, Vinod Kone, and Jiang Yan Xu.
Repository: mesos
Description
-------
Used recursive bind mounts for volumes.
This is for the case where the volume source itself contains mounts. This will become common when we start to support image as the source of a volume.
Diffs
-----
src/slave/containerizer/isolators/filesystem/linux.cpp f36424e94c380870cfde49d55af397fa3dc4a612
Diff: https://reviews.apache.org/r/37734/diff/
Testing
-------
sudo make check
Thanks,
Jie Yu
Re: Review Request 37734: Used recursive bind mounts for volumes.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37734/#review96455
-----------------------------------------------------------
Ship it!
Not exactly necessary for now but ship it considering this is future proof for a certain way of implementing OverlayfsBackend for certain kernels (3.18 kernel supports overlayfs but not multiple lower layers).
- Jiang Yan Xu
On Aug. 24, 2015, 4 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37734/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2015, 4 p.m.)
>
>
> Review request for mesos, Timothy Chen, Vinod Kone, and Jiang Yan Xu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Used recursive bind mounts for volumes.
>
> This is for the case where the volume source itself contains mounts. This will become common when we start to support image as the source of a volume.
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/filesystem/linux.cpp f36424e94c380870cfde49d55af397fa3dc4a612
>
> Diff: https://reviews.apache.org/r/37734/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>