You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "codecov-io (GitHub)" <gi...@apache.org> on 2019/01/04 07:48:17 UTC
[GitHub] [incubator-dubbo] codecov-io commented on issue #3065: [Dubbo - 2.6.x TagRouter Feature] Import old TagRouter into 2.6.x

# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3065?src=pr&el=h1) Report
> Merging [#3065](https://codecov.io/gh/apache/incubator-dubbo/pull/3065?src=pr&el=desc) into [2.6.x](https://codecov.io/gh/apache/incubator-dubbo/commit/ac49a7d34ac6cfe5ff089d9823bdad1171409c00?src=pr&el=desc) will **decrease** coverage by `0.15%`.
> The diff coverage is `76.92%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/3065?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##              2.6.x   #3065      +/-   ##
===========================================
- Coverage     47.36%   47.2%   -0.16%     
- Complexity     4289    4298       +9     
===========================================
  Files           552     555       +3     
  Lines         24381   24409      +28     
  Branches       4314    4319       +5     
===========================================
- Hits          11547   11522      -25     
- Misses        11047   11096      +49     
- Partials       1787    1791       +4
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3065?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../main/java/com/alibaba/dubbo/common/Constants.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL0NvbnN0YW50cy5qYXZh) | `88.88% <ø> (ø)` | `1 <0> (ø)` | :arrow_down: |
| [.../dubbo/registry/integration/RegistryDirectory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcmVnaXN0cnkvaW50ZWdyYXRpb24vUmVnaXN0cnlEaXJlY3RvcnkuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../dubbo/rpc/cluster/router/script/ScriptRouter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9jbHVzdGVyL3JvdXRlci9zY3JpcHQvU2NyaXB0Um91dGVyLmphdmE=) | `61.53% <100%> (+4.72%)` | `4 <0> (-1)` | :arrow_down: |
| [.../rpc/cluster/router/condition/ConditionRouter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9jbHVzdGVyL3JvdXRlci9jb25kaXRpb24vQ29uZGl0aW9uUm91dGVyLmphdmE=) | `71.64% <100%> (ø)` | `33 <0> (ø)` | :arrow_down: |
| [...dubbo/rpc/cluster/router/tag/TagRouterFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9jbHVzdGVyL3JvdXRlci90YWcvVGFnUm91dGVyRmFjdG9yeS5qYXZh) | `100% <100%> (ø)` | `2 <2> (?)` | |
| [...dubbo/rpc/cluster/router/MockInvokersSelector.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9jbHVzdGVyL3JvdXRlci9Nb2NrSW52b2tlcnNTZWxlY3Rvci5qYXZh) | `94.11% <100%> (ø)` | `15 <1> (-2)` | :arrow_down: |
| [...om/alibaba/dubbo/config/AbstractServiceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvQWJzdHJhY3RTZXJ2aWNlQ29uZmlnLmphdmE=) | `95.58% <33.33%> (-2.88%)` | `42 <1> (+1)` | |
| [...ibaba/dubbo/rpc/cluster/router/AbstractRouter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9jbHVzdGVyL3JvdXRlci9BYnN0cmFjdFJvdXRlci5qYXZh) | `75% <75%> (ø)` | `4 <4> (?)` | |
| [...libaba/dubbo/rpc/cluster/router/tag/TagRouter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9jbHVzdGVyL3JvdXRlci90YWcvVGFnUm91dGVyLmphdmE=) | `79.16% <79.16%> (ø)` | `9 <9> (?)` | |
| [...aba/dubbo/common/compiler/support/JdkCompiler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL2NvbXBpbGVyL3N1cHBvcnQvSmRrQ29tcGlsZXIuamF2YQ==) | `0% <0%> (-61.82%)` | `0% <0%> (-2%)` | |
| ... and [20 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3065?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3065?src=pr&el=footer). Last update [ac49a7d...340139b](https://codecov.io/gh/apache/incubator-dubbo/pull/3065?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3065 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org