You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "maximilian-novikov-db (via GitHub)" <gi...@apache.org> on 2023/08/18 17:21:07 UTC

[GitHub] [maven-build-cache-extension] maximilian-novikov-db commented on a diff in pull request #92: [MBUILDCACHE-67] Bugfix artefact restoration error not handled properly

maximilian-novikov-db commented on code in PR #92:
URL: https://github.com/apache/maven-build-cache-extension/pull/92#discussion_r1298686503


##########
src/main/java/org/apache/maven/buildcache/BuildCacheMojosExecutionStrategy.java:
##########
@@ -129,7 +129,8 @@ public void execute(
             boolean restored = result.isSuccess(); // if partially restored need to save increment
             if (restorable) {
                 restored &= restoreProject(result, mojoExecutions, mojoExecutionRunner, cacheConfig);
-            } else {
+            }
+            if (!restored) {

Review Comment:
   perhaps we need to execute all mojos in this case including for Clean phase to remove any "garbage" which could left after an unsuccessful restore



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org