You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Till Toenshoff <to...@me.com> on 2016/02/04 09:42:24 UTC

Re: Review Request 41871: Replaced libtool with dolt to speed up compiler invocations.


> On Jan. 5, 2016, 9:03 a.m., Joerg Schad wrote:
> > configure.ac, line 46
> > <https://reviews.apache.org/r/41871/diff/2/?file=1181040#file1181040line46>
> >
> >     General comment: As this adds another tool to our build chain, should we have a brief discussion on the dev mailing list?

That discussion was triggered by Benjamin, but unfortunately the feedback was rather minimal.


- Till


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41871/#review112799
-----------------------------------------------------------


On Jan. 11, 2016, 5:22 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41871/
> -----------------------------------------------------------
> 
> (Updated Jan. 11, 2016, 5:22 p.m.)
> 
> 
> Review request for mesos, Joerg Schad, Michael Park, and Till Toenshoff.
> 
> 
> Bugs: MESOS-4271
>     https://issues.apache.org/jira/browse/MESOS-4271
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The added m4 macro definitions come from
> git://anongit.freedesktop.org/git/dolt revision
> 2eae53fa6d31175e9de62a312cc2191fd8a25cb7.
> 
> Review: https://reviews.apache.org/r/41871
> 
> 
> Diffs
> -----
> 
>   Makefile.am fbd4e5a6356e90c867ba47c48c86fc9161ddd98e 
>   configure.ac 40d60a63cdba41d06305f09141f4d14d6e229d95 
>   m4/dolt.m4 PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41871/diff/
> 
> 
> Testing
> -------
> 
> make
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>