You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by "bruno rovagnati (JIRA)" <ji...@apache.org> on 2008/10/09 21:34:44 UTC
[jira] Created: (SHINDIG-650) missing implementation of
RestRequestItem()->createRequestItemWithRequest()
missing implementation of RestRequestItem()->createRequestItemWithRequest()
---------------------------------------------------------------------------
Key: SHINDIG-650
URL: https://issues.apache.org/jira/browse/SHINDIG-650
Project: Shindig
Issue Type: Bug
Components: RESTful API (PHP)
Reporter: bruno rovagnati
createRequestItemWithRequest() is called in RestServlet.php line 164
$requestItem = new RestRequestItem();
$requestItem->createRequestItemWithRequest($value, $token);
$responses[$key] = $this->getResponseItem($requestItem);
but is not implemented (was removed in the latest update)
this also break unittests
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Created: (SHINDIG-650) missing implementation of RestRequestItem()->createRequestItemWithRequest()
Posted by Chris Chabot <ch...@google.com>.
turns out that was some not-yet-ported code (haven't looked at the
MessageHandler yet), and a stale file (RestServlet.php wasn't meant to be
there, the rest serlvet is now DataServiceServlet)
On Thu, Oct 9, 2008 at 9:54 PM, Ropu <ro...@gmail.com> wrote:
> Same issue with
>
> parseUrlWithTemplate();
>
> used in MessageHandler() line 54
>
> $requestItem->parseUrlWithTemplate(self::$MESSAGES_PATH);
> return
> $this->service->createMessage($requestItem->getUser(),
> $requestItem->getPostData(), $requestItem->getToken());
>
>
> and it also breaks unit tests, (RestRequestItemTest)
>
>
>
> ropu
>
>
>
> On Thu, Oct 9, 2008 at 5:34 PM, bruno rovagnati (JIRA) <jira@apache.org
> >wrote:
>
> > missing implementation of
> RestRequestItem()->createRequestItemWithRequest()
> >
> ---------------------------------------------------------------------------
> >
> > Key: SHINDIG-650
> > URL: https://issues.apache.org/jira/browse/SHINDIG-650
> > Project: Shindig
> > Issue Type: Bug
> > Components: RESTful API (PHP)
> > Reporter: bruno rovagnati
> >
> >
> > createRequestItemWithRequest() is called in RestServlet.php line 164
> >
> > $requestItem = new RestRequestItem();
> >
> > $requestItem->createRequestItemWithRequest($value, $token);
> > $responses[$key] =
> > $this->getResponseItem($requestItem);
> >
> > but is not implemented (was removed in the latest update)
> >
> > this also break unittests
> >
> >
> >
> > --
> > This message is automatically generated by JIRA.
> > -
> > You can reply to this email to add a comment to the issue online.
> >
> >
>
>
> --
> .-. --- .--. ..-
> R o p u
>
Re: [jira] Created: (SHINDIG-650) missing implementation of RestRequestItem()->createRequestItemWithRequest()
Posted by Ropu <ro...@gmail.com>.
Same issue with
parseUrlWithTemplate();
used in MessageHandler() line 54
$requestItem->parseUrlWithTemplate(self::$MESSAGES_PATH);
return $this->service->createMessage($requestItem->getUser(),
$requestItem->getPostData(), $requestItem->getToken());
and it also breaks unit tests, (RestRequestItemTest)
ropu
On Thu, Oct 9, 2008 at 5:34 PM, bruno rovagnati (JIRA) <ji...@apache.org>wrote:
> missing implementation of RestRequestItem()->createRequestItemWithRequest()
> ---------------------------------------------------------------------------
>
> Key: SHINDIG-650
> URL: https://issues.apache.org/jira/browse/SHINDIG-650
> Project: Shindig
> Issue Type: Bug
> Components: RESTful API (PHP)
> Reporter: bruno rovagnati
>
>
> createRequestItemWithRequest() is called in RestServlet.php line 164
>
> $requestItem = new RestRequestItem();
>
> $requestItem->createRequestItemWithRequest($value, $token);
> $responses[$key] =
> $this->getResponseItem($requestItem);
>
> but is not implemented (was removed in the latest update)
>
> this also break unittests
>
>
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
--
.-. --- .--. ..-
R o p u
[jira] Resolved: (SHINDIG-650) missing implementation of
RestRequestItem()->createRequestItemWithRequest()
Posted by "Chris Chabot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Chabot resolved SHINDIG-650.
----------------------------------
Resolution: Fixed
In the case of the MessageHandler it's a bit of old code (pre json-rpc / social api rewrite) that still has a reference to the old way of working.
For the rest all these references were in RestServlet.php, which was an old stale file.
MessageHandler will need fixing, but thats another bug all together :)
> missing implementation of RestRequestItem()->createRequestItemWithRequest()
> ---------------------------------------------------------------------------
>
> Key: SHINDIG-650
> URL: https://issues.apache.org/jira/browse/SHINDIG-650
> Project: Shindig
> Issue Type: Bug
> Components: RESTful API (PHP)
> Reporter: bruno rovagnati
>
> createRequestItemWithRequest() is called in RestServlet.php line 164
> $requestItem = new RestRequestItem();
> $requestItem->createRequestItemWithRequest($value, $token);
> $responses[$key] = $this->getResponseItem($requestItem);
> but is not implemented (was removed in the latest update)
> this also break unittests
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-650) missing implementation of
RestRequestItem()->createRequestItemWithRequest()
Posted by "bruno rovagnati (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12638377#action_12638377 ]
bruno rovagnati commented on SHINDIG-650:
-----------------------------------------
Same issue with
parseUrlWithTemplate();
used in MessageHandler() line 54
$requestItem->parseUrlWithTemplate(self::$MESSAGES_PATH);
return $this->service->createMessage($requestItem->getUser(), $requestItem->getPostData(), $requestItem->getToken());
also
getPostData()
and
createRequestItem()
are missing in the RestRequestItem class
> missing implementation of RestRequestItem()->createRequestItemWithRequest()
> ---------------------------------------------------------------------------
>
> Key: SHINDIG-650
> URL: https://issues.apache.org/jira/browse/SHINDIG-650
> Project: Shindig
> Issue Type: Bug
> Components: RESTful API (PHP)
> Reporter: bruno rovagnati
>
> createRequestItemWithRequest() is called in RestServlet.php line 164
> $requestItem = new RestRequestItem();
> $requestItem->createRequestItemWithRequest($value, $token);
> $responses[$key] = $this->getResponseItem($requestItem);
> but is not implemented (was removed in the latest update)
> this also break unittests
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.