You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@impala.apache.org by "Joe McDonnell (JIRA)" <ji...@apache.org> on 2017/05/11 00:24:04 UTC

[jira] [Resolved] (IMPALA-5258) Need to reenable building Impala-lzo in release mode

     [ https://issues.apache.org/jira/browse/IMPALA-5258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Joe McDonnell resolved IMPALA-5258.
-----------------------------------
       Resolution: Fixed
    Fix Version/s: Impala 2.9.0

commit ff5b0469b1a718d8e84976c9946752cfce0e357f
Author: Joe McDonnell <jo...@cloudera.com>
Date:   Thu Apr 27 14:20:07 2017 -0700

    IMPALA-5258: Pass CMAKE_BUILD_TYPE to Impala-lzo
    
    Impala-lzo contained a buffer overrun that was only
    present when compiled in optimized mode. To avoid this
    (IMPALA-5172), Impala-lzo is only compiled in DEBUG mode.
    Since the underlying buffer overrun has been resolved,
    reenable passing the CMAKE_BUILD_TYPE down to Impala-lzo.
    
    Change-Id: I190d732a8244dd79bc422cc0c563fb09ba2ed561
    Reviewed-on: http://gerrit.cloudera.org:8080/6751
    Reviewed-by: Alex Behm <al...@cloudera.com>
    Tested-by: Impala Public Jenkins


> Need to reenable building Impala-lzo in release mode
> ----------------------------------------------------
>
>                 Key: IMPALA-5258
>                 URL: https://issues.apache.org/jira/browse/IMPALA-5258
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Backend
>    Affects Versions: Impala 2.9.0
>            Reporter: Joe McDonnell
>            Assignee: Joe McDonnell
>             Fix For: Impala 2.9.0
>
>
> In IMPALA-5172, we disabled building Impala-lzo in RELEASE mode by always passing in DEBUG as the CMAKE_BUILD_TYPE, as hdfs-lzo-text-scanner.cc contained a buffer overrun when compiled in RELEASE mode. The underlying buffer overrun has been resolved, so Impala-lzo should now use whatever CMAKE_BUILD_TYPE that is used for Impala.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)