You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jmeter.apache.org by pm...@apache.org on 2016/12/21 13:49:48 UTC
svn commit: r1775420 - in /jmeter/trunk/src:
components/org/apache/jmeter/assertions/CompareAssertion.java
core/org/apache/jmeter/threads/AbstractThreadGroup.java
jorphan/org/apache/jorphan/gui/AbstractTreeTableModel.java
Author: pmouawad
Date: Wed Dec 21 13:49:48 2016
New Revision: 1775420
URL: http://svn.apache.org/viewvc?rev=1775420&view=rev
Log:
Sonar : Fix code smells
Modified:
jmeter/trunk/src/components/org/apache/jmeter/assertions/CompareAssertion.java
jmeter/trunk/src/core/org/apache/jmeter/threads/AbstractThreadGroup.java
jmeter/trunk/src/jorphan/org/apache/jorphan/gui/AbstractTreeTableModel.java
Modified: jmeter/trunk/src/components/org/apache/jmeter/assertions/CompareAssertion.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/components/org/apache/jmeter/assertions/CompareAssertion.java?rev=1775420&r1=1775419&r2=1775420&view=diff
==============================================================================
--- jmeter/trunk/src/components/org/apache/jmeter/assertions/CompareAssertion.java (original)
+++ jmeter/trunk/src/components/org/apache/jmeter/assertions/CompareAssertion.java Wed Dec 21 13:49:48 2016
@@ -39,7 +39,7 @@ public class CompareAssertion extends Ab
private transient List<SampleResult> responses;
- private transient final StringSubstitution emptySub = new StringSubstitution(""); //$NON-NLS-1$
+ private final transient StringSubstitution emptySub = new StringSubstitution(""); //$NON-NLS-1$
private boolean compareContent = true;
Modified: jmeter/trunk/src/core/org/apache/jmeter/threads/AbstractThreadGroup.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/threads/AbstractThreadGroup.java?rev=1775420&r1=1775419&r2=1775420&view=diff
==============================================================================
--- jmeter/trunk/src/core/org/apache/jmeter/threads/AbstractThreadGroup.java (original)
+++ jmeter/trunk/src/core/org/apache/jmeter/threads/AbstractThreadGroup.java Wed Dec 21 13:49:48 2016
@@ -46,7 +46,7 @@ public abstract class AbstractThreadGrou
private static final long serialVersionUID = 240L;
// Only create the map if it is required
- private transient final ConcurrentMap<TestElement, Object> children = new ConcurrentHashMap<>();
+ private final transient ConcurrentMap<TestElement, Object> children = new ConcurrentHashMap<>();
private static final Object DUMMY = new Object();
Modified: jmeter/trunk/src/jorphan/org/apache/jorphan/gui/AbstractTreeTableModel.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/jorphan/org/apache/jorphan/gui/AbstractTreeTableModel.java?rev=1775420&r1=1775419&r2=1775420&view=diff
==============================================================================
--- jmeter/trunk/src/jorphan/org/apache/jorphan/gui/AbstractTreeTableModel.java (original)
+++ jmeter/trunk/src/jorphan/org/apache/jorphan/gui/AbstractTreeTableModel.java Wed Dec 21 13:49:48 2016
@@ -36,15 +36,15 @@ public abstract class AbstractTreeTableM
protected final TreeNode rootNode;
protected final EventListenerList listener = new EventListenerList();
- protected transient final List<Object> objects = new ArrayList<>();
+ protected final transient List<Object> objects = new ArrayList<>();
- protected transient final List<String> headers = new ArrayList<>();
+ protected final transient List<String> headers = new ArrayList<>();
- protected transient final List<Class<?>> classes = new ArrayList<>();
+ protected final transient List<Class<?>> classes = new ArrayList<>();
- protected transient final List<Functor> readFunctors;
+ protected final transient List<Functor> readFunctors;
- protected transient final List<Functor> writeFunctors;
+ protected final transient List<Functor> writeFunctors;
public AbstractTreeTableModel(TreeNode root) {
this.rootNode = root;