You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@linkis.apache.org by GitBox <gi...@apache.org> on 2022/07/03 13:46:36 UTC

[GitHub] [incubator-linkis] gabeng1996 opened a new pull request, #2405: scala version

gabeng1996 opened a new pull request, #2405:
URL: https://github.com/apache/incubator-linkis/pull/2405

   ### What is the purpose of the change
   This change makes spark_plugin compatible with scala 2.12 and allows users to choose the scala version through configuration.
   
   ### Brief change log
   - Add the configuration of spark_scala_version in the linkis-engineconn-plugins\engineconn-plugins\spark\src\main\scala\org\apache\linkis\engineplugin\spark\config\SparkConfiguration;
   - The val in0 is defined by spark_scala_version.
   
   ### Verifying this change
   This change is already covered by existing tests.  
   
   
   ### Does this pull request potentially affect one of the following parts:
   - Dependencies (does it add or upgrade a dependency): (no)
   - Anything that affects deployment: (no)
   - The MGS(Microservice Governance Services), i.e., Spring Cloud Gateway, OpenFeign, Eureka.: (no)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org


[GitHub] [incubator-linkis] peacewong merged pull request #2405: Support scala multi-version of spark

Posted by GitBox <gi...@apache.org>.
peacewong merged PR #2405:
URL: https://github.com/apache/incubator-linkis/pull/2405


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org


[GitHub] [incubator-linkis] codecov[bot] commented on pull request #2405: Support scala multi-version of spark

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #2405:
URL: https://github.com/apache/incubator-linkis/pull/2405#issuecomment-1173098601

   # [Codecov](https://codecov.io/gh/apache/incubator-linkis/pull/2405?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2405](https://codecov.io/gh/apache/incubator-linkis/pull/2405?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4680dfc) into [dev-1.2.0](https://codecov.io/gh/apache/incubator-linkis/commit/84a48a0010850cd84172e2854f2f369db3a257d2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (84a48a0) will **decrease** coverage by `0.01%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@               Coverage Diff               @@
   ##             dev-1.2.0    #2405      +/-   ##
   ===============================================
   - Coverage        17.78%   17.77%   -0.02%     
   + Complexity        1077     1076       -1     
   ===============================================
     Files              595      595              
     Lines            17668    17669       +1     
     Branches          2673     2674       +1     
   ===============================================
   - Hits              3143     3141       -2     
   - Misses           14092    14094       +2     
   - Partials           433      434       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-linkis/pull/2405?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...a/org/apache/linkis/scheduler/queue/Consumer.scala](https://codecov.io/gh/apache/incubator-linkis/pull/2405/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLXNjaGVkdWxlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9zY2hlZHVsZXIvcXVldWUvQ29uc3VtZXIuc2NhbGE=) | `57.14% <0.00%> (-14.29%)` | :arrow_down: |
   | [...s/scheduler/queue/fifoqueue/FIFOUserConsumer.scala](https://codecov.io/gh/apache/incubator-linkis/pull/2405/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLXNjaGVkdWxlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9zY2hlZHVsZXIvcXVldWUvZmlmb3F1ZXVlL0ZJRk9Vc2VyQ29uc3VtZXIuc2NhbGE=) | `33.33% <0.00%> (-1.12%)` | :arrow_down: |
   | [...eplugin/jdbc/executer/JDBCEngineConnExecutor.scala](https://codecov.io/gh/apache/incubator-linkis/pull/2405/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWVuZ2luZWNvbm4tcGx1Z2lucy9lbmdpbmVjb25uLXBsdWdpbnMvamRiYy9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9tYW5hZ2VyL2VuZ2luZXBsdWdpbi9qZGJjL2V4ZWN1dGVyL0pEQkNFbmdpbmVDb25uRXhlY3V0b3Iuc2NhbGE=) | `12.90% <0.00%> (-0.09%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-linkis/pull/2405?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-linkis/pull/2405?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [84a48a0...4680dfc](https://codecov.io/gh/apache/incubator-linkis/pull/2405?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org