You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/12 01:53:13 UTC
[GitHub] [arrow] cyb70289 opened a new pull request #10298: ARROW-12490: [Dev] Use only miniforge in verify-release-candidate.sh
cyb70289 opened a new pull request #10298:
URL: https://github.com/apache/arrow/pull/10298
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] cyb70289 removed a comment on pull request #10298: ARROW-12490: [Dev] Use only miniforge in verify-release-candidate.sh
Posted by GitBox <gi...@apache.org>.
cyb70289 removed a comment on pull request #10298:
URL: https://github.com/apache/arrow/pull/10298#issuecomment-839373461
I tested on `Linux/x86_64`, `Linux/aarch64`, `MacOSX/arm64`, but **not** `MacOSX/x86_64`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] cyb70289 commented on pull request #10298: ARROW-12490: [Dev] Use only miniforge in verify-release-candidate.sh
Posted by GitBox <gi...@apache.org>.
cyb70289 commented on pull request #10298:
URL: https://github.com/apache/arrow/pull/10298#issuecomment-839373461
I tested on `Linux/x86_64`, `Linux/aarch64`, `MacOSX/arm64`, but **not** `MacOSX/x86_64`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] cyb70289 commented on a change in pull request #10298: ARROW-12490: [Dev] Use only miniforge in verify-release-candidate.sh
Posted by GitBox <gi...@apache.org>.
cyb70289 commented on a change in pull request #10298:
URL: https://github.com/apache/arrow/pull/10298#discussion_r630665159
##########
File path: dev/release/verify-release-candidate.sh
##########
@@ -217,17 +217,12 @@ setup_tempdir() {
setup_miniconda() {
# Setup short-lived miniconda for Python and integration tests
- if [ "$(uname)" == "Darwin" ]; then
- if [ "$(uname -m)" == "arm64" ]; then
- MINICONDA_URL=https://github.com/conda-forge/miniforge/releases/latest/download/Miniforge3-MacOSX-arm64.sh
- else
- MINICONDA_URL=https://repo.continuum.io/miniconda/Miniconda3-latest-MacOSX-x86_64.sh
- fi
- elif [ "$(uname)" == "Linux" ] && [ "$(uname -m)" == "aarch64" ]; then
- MINICONDA_URL=https://github.com/conda-forge/miniforge/releases/latest/download/Miniforge3-Linux-aarch64.sh
- else
- MINICONDA_URL=https://repo.continuum.io/miniconda/Miniconda3-latest-Linux-x86_64.sh
+ OS="$(uname)"
+ if [ "${OS}" == "Darwin" ]; then
+ OS=MacOSX
fi
+ ARCH="$(uname -m)"
+ MINICONDA_URL="https://github.com/conda-forge/miniforge/releases/latest/download/Miniforge3-${OS}-${ARCH}.sh"
Review comment:
I tested on `Linux-x86_64`, `Linux-aarch64`, `MacOSX-arm64`, but **not** `MacOSX-x86_64`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #10298: ARROW-12490: [Dev] Use only miniforge in verify-release-candidate.sh
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #10298:
URL: https://github.com/apache/arrow/pull/10298#issuecomment-839818067
@github-actions crossbow submit --param release=4.0.0 --param rc=3 verify-rc-source-linux-cpp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10298: ARROW-12490: [Dev] Use only miniforge in verify-release-candidate.sh
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10298:
URL: https://github.com/apache/arrow/pull/10298#issuecomment-839372319
https://issues.apache.org/jira/browse/ARROW-12490
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #10298: ARROW-12490: [Dev] Use only miniforge in verify-release-candidate.sh
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #10298:
URL: https://github.com/apache/arrow/pull/10298#issuecomment-839669484
@github-actions crossbow submit --param release=4.0.0 --param rc=3 verify-rc-source-*-cpp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10298: ARROW-12490: [Dev] Use only miniforge in verify-release-candidate.sh
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10298:
URL: https://github.com/apache/arrow/pull/10298#issuecomment-839685052
Revision: ce46d18cf24efa8a23c34a734a32b2456fe9ffa3
Submitted crossbow builds: [ursacomputing/crossbow @ actions-401](https://github.com/ursacomputing/crossbow/branches/all?query=actions-401)
|Task|Status|
|----|------|
|verify-rc-source-linux-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-401-github-verify-rc-source-linux-cpp)|
|verify-rc-source-macos-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-401-github-verify-rc-source-macos-cpp)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10298: ARROW-12490: [Dev] Use only miniforge in verify-release-candidate.sh
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10298:
URL: https://github.com/apache/arrow/pull/10298#issuecomment-839876326
Revision: e4af763461d225df4abda829d98dc35581618d5c
Submitted crossbow builds: [ursacomputing/crossbow @ actions-403](https://github.com/ursacomputing/crossbow/branches/all?query=actions-403)
|Task|Status|
|----|------|
|verify-rc-source-linux-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-403-github-verify-rc-source-linux-cpp)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs closed pull request #10298: ARROW-12490: [Dev] Use only miniforge in verify-release-candidate.sh
Posted by GitBox <gi...@apache.org>.
kszucs closed pull request #10298:
URL: https://github.com/apache/arrow/pull/10298
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org