[jira] [Commented] (SAMZA-81) Exception logging in KafkaSystemConsumer should not be at debug

["Chris Riccomini (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SAMZA-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13817992#comment-13817992 ] 

Chris Riccomini commented on SAMZA-81:
--------------------------------------

Both you and [~jkreps] are fighting me on this.

I intentionally set the stack trace to debug because this is non-fatal most of the time. The issue is that, when a Kafka connection fails, we just wait and retry. I didn't want the log to be full of useless stack traces -- hence only dumping on debug. This already happens with most of the systems we use, and one of two things happen:

1. People worry about every stack trace they see, because they think something bad happened.
2. People ignore all stack traces because there are too many, and some actually ARE bad.

Given that everyone seems to disagree with me, I'm fine switching from debug() to warn() in these cases, but could you update the patch to do it everywhere?

> Exception logging in KafkaSystemConsumer should not be at debug
> ---------------------------------------------------------------
>
>                 Key: SAMZA-81
>                 URL: https://issues.apache.org/jira/browse/SAMZA-81
>             Project: Samza
>          Issue Type: Bug
>            Reporter: Jakob Homan
>            Assignee: Jakob Homan
>         Attachments: SAMZA-81.patch
>
>
> When encountering an exception while fetching metadata, we warn that something was encountered, but don't share what it actually was.



--
This message was sent by Atlassian JIRA
(v6.1#6144)