You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jinmei Liao <ji...@pivotal.io> on 2016/11/01 17:18:46 UTC
Re: Review Request 53274: GEODE-1955: fix flaky tests by properly
closing the gfsh instance in ConnectToLocatorSSLDUnitTest
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53274/
-----------------------------------------------------------
(Updated Nov. 1, 2016, 5:18 p.m.)
Review request for geode, Kevin Duling and Kirk Lund.
Repository: geode
Description
-------
GEODE-1955: fix flaky tests by properly closing the gfsh instance in ConnectToLocatorSSLDUnitTest
Diffs (updated)
-----
geode-core/src/test/java/org/apache/geode/management/ConnectToLocatorSSLDUnitTest.java 8426c6f52129472c9c0def172aeefd10f1491935
geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshShellConnectionRule.java 25780e67dd3f7920e53162ef9400d2845e4c958b
Diff: https://reviews.apache.org/r/53274/diff/
Testing
-------
Thanks,
Jinmei Liao
Re: Review Request 53274: GEODE-1955: fix flaky tests by properly
closing the gfsh instance in ConnectToLocatorSSLDUnitTest
Posted by Jinmei Liao <ji...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53274/
-----------------------------------------------------------
(Updated Nov. 3, 2016, 7:38 p.m.)
Review request for geode, Kevin Duling and Kirk Lund.
Repository: geode
Description
-------
GEODE-1955: fix flaky tests by properly closing the gfsh instance in ConnectToLocatorSSLDUnitTest
Diffs
-----
geode-core/src/test/java/org/apache/geode/management/ConnectToLocatorSSLDUnitTest.java 8426c6f52129472c9c0def172aeefd10f1491935
geode-core/src/test/java/org/apache/geode/management/internal/security/GfshCommandsPostProcessorTest.java d3390ba6ce2990d05516b701f82d5f176e6f4d49
geode-core/src/test/java/org/apache/geode/management/internal/security/GfshCommandsSecurityTest.java b2dc6fe334499456184e1d0cbc0297063d4c99ce
geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshShellConnectionRule.java 25780e67dd3f7920e53162ef9400d2845e4c958b
geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java 4e10b0acae6c6aac88b6039560e4cf65b0a012cb
geode-web/src/test/java/org/apache/geode/management/internal/security/GfshCommandsOverHttpSecurityTest.java d4775659c0ff2704fd55a3840fc3751e66886d26
Diff: https://reviews.apache.org/r/53274/diff/
Testing (updated)
-------
precheckin successful
Thanks,
Jinmei Liao
Re: Review Request 53274: GEODE-1955: fix flaky tests by properly
closing the gfsh instance in ConnectToLocatorSSLDUnitTest
Posted by Jinmei Liao <ji...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53274/
-----------------------------------------------------------
(Updated Nov. 1, 2016, 5:19 p.m.)
Review request for geode, Kevin Duling and Kirk Lund.
Repository: geode
Description
-------
GEODE-1955: fix flaky tests by properly closing the gfsh instance in ConnectToLocatorSSLDUnitTest
Diffs (updated)
-----
geode-core/src/test/java/org/apache/geode/management/ConnectToLocatorSSLDUnitTest.java 8426c6f52129472c9c0def172aeefd10f1491935
geode-core/src/test/java/org/apache/geode/management/internal/security/GfshCommandsPostProcessorTest.java d3390ba6ce2990d05516b701f82d5f176e6f4d49
geode-core/src/test/java/org/apache/geode/management/internal/security/GfshCommandsSecurityTest.java b2dc6fe334499456184e1d0cbc0297063d4c99ce
geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshShellConnectionRule.java 25780e67dd3f7920e53162ef9400d2845e4c958b
geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java 4e10b0acae6c6aac88b6039560e4cf65b0a012cb
geode-web/src/test/java/org/apache/geode/management/internal/security/GfshCommandsOverHttpSecurityTest.java d4775659c0ff2704fd55a3840fc3751e66886d26
Diff: https://reviews.apache.org/r/53274/diff/
Testing
-------
Thanks,
Jinmei Liao