You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/12/24 23:27:31 UTC
[GitHub] [spark] HeartSaVioR commented on issue #26992:
[SPARK-30337][SQL][SS] Change case class with vars to normal class in
spark-sql-kafka module
HeartSaVioR commented on issue #26992: [SPARK-30337][SQL][SS] Change case class with vars to normal class in spark-sql-kafka module
URL: https://github.com/apache/spark/pull/26992#issuecomment-568810596
Good point, and I'm seeing a spot logging out the FetchData instance which should have toString implementation (at least). If we don't feel pretty bad on having vars in case classes we may just remove the TODO comments and leave them as they are. (The PR can be changed to MINOR then.) WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org