You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/08/25 10:16:59 UTC
[GitHub] [tvm] NicolaLancellotti opened a new pull request, #12594: [ETHOSN] Improve inferring new shape of the Reshape operator
NicolaLancellotti opened a new pull request, #12594:
URL: https://github.com/apache/tvm/pull/12594
This pr improves the inference of the new shape of the Reshape operator for the Arm(R) Ethos(TM)-N NPU.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] lhutton1 commented on a diff in pull request #12594: [ETHOSN] Improve inferring new shape of the Reshape operator
Posted by GitBox <gi...@apache.org>.
lhutton1 commented on code in PR #12594:
URL: https://github.com/apache/tvm/pull/12594#discussion_r955177020
##########
src/relay/backend/contrib/ethosn/ethosn_api.cc:
##########
@@ -305,10 +304,15 @@ EthosnError EthosnAPI::Reshape(const Expr& expr, ReshapeParams* params) {
tensor_size *= dim;
Review Comment:
Seems that `tensor_size` doesn't get used? I think we can remove this code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] NicolaLancellotti commented on pull request #12594: [ETHOSN] Improve inferring new shape of the Reshape operator
Posted by GitBox <gi...@apache.org>.
NicolaLancellotti commented on PR #12594:
URL: https://github.com/apache/tvm/pull/12594#issuecomment-1227071859
@lhutton1 @leandron
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] lhutton1 commented on pull request #12594: [ETHOSN] Improve inferring new shape of the Reshape operator
Posted by GitBox <gi...@apache.org>.
lhutton1 commented on PR #12594:
URL: https://github.com/apache/tvm/pull/12594#issuecomment-1232724622
Thanks @NicolaLancellotti!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] NicolaLancellotti commented on pull request #12594: [ETHOSN] Improve inferring new shape of the Reshape operator
Posted by GitBox <gi...@apache.org>.
NicolaLancellotti commented on PR #12594:
URL: https://github.com/apache/tvm/pull/12594#issuecomment-1232675489
> After reading [apache/tvm-rfcs#88](https://github.com/apache/tvm-rfcs/pull/88) I think we should quickly update the PR body to be more specific about the fix, WDYT? (No need to push a new commit, I can change the commit message so it matches the PR)
It is good to me to update the PR body.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] lhutton1 merged pull request #12594: [ETHOSN] Improve inferring new shape of the Reshape operator
Posted by GitBox <gi...@apache.org>.
lhutton1 merged PR #12594:
URL: https://github.com/apache/tvm/pull/12594
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] lhutton1 commented on pull request #12594: [ETHOSN] Improve inferring new shape of the Reshape operator
Posted by GitBox <gi...@apache.org>.
lhutton1 commented on PR #12594:
URL: https://github.com/apache/tvm/pull/12594#issuecomment-1232617565
After reading https://github.com/apache/tvm-rfcs/pull/88 I think we should quickly update the commit body to be more specific about the fix, WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org