You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/07/29 17:47:11 UTC

[GitHub] [incubator-echarts] Hansz00 opened a new pull request #13047: Aira Separator Update

Hansz00 opened a new pull request #13047:
URL: https://github.com/apache/incubator-echarts/pull/13047


   <!-- Please fill in the following information to help us review your PR more efficiently. -->
   
   ## Brief Information
   
   This pull request is in the type of:
   
   - [ ] bug fixing
   - [ ] new feature
   - [x] others
   
   
   
   ### What does this PR do?
   
   Changed the separator of generating description of the chart.
   
   
   ### Fixed issues
   
   <!--
   - #xxxx: ...
   -->
   
   
   ## Details
   
   ### Before: What was the problem?
   
   There are no space after comma in the description of the chart (only in english version).
   
   
   
   ### After: How is it fixed in this PR?
   
   Change
   
   ```
   separator: {
                   middle: ',',
                   end: '.'
               }
   ```
   to
   ```
   separator: {
                   middle: ', ',
                   end: '.'
               }
   ```
   
   ### Are there any API changes?
   
   No.
   
   ### Merging options
   
   - [ ] Please squash the commits into a single one when merge.
   
   ### Other information
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #13047: Aira Separator Update

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #13047:
URL: https://github.com/apache/incubator-echarts/pull/13047#issuecomment-665644301


   Thanks for your contribution!
   The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #13047: Aira Separator Update

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #13047:
URL: https://github.com/apache/incubator-echarts/pull/13047#issuecomment-666048189


   Congratulations! Your PR has been merged. Thanks for your contribution! 👍


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] Ovilia merged pull request #13047: Aira Separator Update

Posted by GitBox <gi...@apache.org>.
Ovilia merged pull request #13047:
URL: https://github.com/apache/incubator-echarts/pull/13047


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] pissang commented on pull request #13047: Aira Separator Update

Posted by GitBox <gi...@apache.org>.
pissang commented on pull request #13047:
URL: https://github.com/apache/incubator-echarts/pull/13047#issuecomment-665656899


   Please modify the source file instead of distribution file


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org