You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/10/24 20:47:25 UTC
[GitHub] williaster opened a new pull request #6180: [sqllab] more robust
copy to clipboard
williaster opened a new pull request #6180: [sqllab] more robust copy to clipboard
URL: https://github.com/apache/incubator-superset/pull/6180
This PR
- Closes #6140 by implementing a more robust copy to clip board for SQL lab share query links
- Removes the shared query link from the SQL lab menu dropdown (so, share query is only available in the main SQL lab editor)
<img width="1436" alt="screen shot 2018-10-24 at 1 36 19 pm" src="https://user-images.githubusercontent.com/4496521/47460418-4e61d980-d793-11e8-8249-7078656cf1c7.png">
- Fixes share query offset in explore view. This had the wrong offset because we render once without the url, then render again with the url, but the react-bootstrap popover was not updating its position on the 2nd render
**before**
**after**
<img width="474" alt="screen shot 2018-10-24 at 1 36 05 pm" src="https://user-images.githubusercontent.com/4496521/47460249-e57a6180-d792-11e8-9e83-a928461ab933.png">
@kristw @michellethomas @graceguo-supercat @mistercrunch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org