You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2020/11/05 15:36:23 UTC
[GitHub] [zookeeper] belugabehr opened a new pull request #1361: ZOOKEEPER-3840: Use JDK 8 Facilities to Synchronize Access to DataTre…
belugabehr opened a new pull request #1361:
URL: https://github.com/apache/zookeeper/pull/1361
…e Ephemerals
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] belugabehr closed pull request #1361: ZOOKEEPER-3840: Use JDK 8 Facilities to Synchronize Access to DataTre…
Posted by GitBox <gi...@apache.org>.
belugabehr closed pull request #1361:
URL: https://github.com/apache/zookeeper/pull/1361
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] belugabehr commented on a change in pull request #1361: ZOOKEEPER-3840: Use JDK 8 Facilities to Synchronize Access to DataTre…
Posted by GitBox <gi...@apache.org>.
belugabehr commented on a change in pull request #1361:
URL: https://github.com/apache/zookeeper/pull/1361#discussion_r427454605
##########
File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/DataTree.java
##########
@@ -1407,12 +1391,8 @@ public void deserialize(InputArchive ia, String tag) throws IOException {
} else if (ephemeralType == EphemeralType.TTL) {
ttls.add(path);
} else if (eowner != 0) {
- HashSet<String> list = ephemerals.get(eowner);
- if (list == null) {
- list = new HashSet<String>();
- ephemerals.put(eowner, list);
- }
- list.add(path);
Review comment:
This is `synchronized` in `deleteNode` but not here. Not sure if it matters.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org