You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/01/27 15:59:05 UTC
[GitHub] [airflow] LaPetiteSouris opened a new pull request #21159: [SQSSensor] Add opt-in to disable auto-delete messages on consumption
LaPetiteSouris opened a new pull request #21159:
URL: https://github.com/apache/airflow/pull/21159
## What
Add opt-in in `SQSSensor` to disable the behavior of automatically delete messages on consumption. This option is opt-in. By default it is set to `False`, which means the original feature is preserved:
`SQS messages are deleted automatically from the queue upon consumption`
## Why
In many cases, the `SQSSensor` itselft is not the part of the code base that actually processes the messages. It serves as a short of polling to get messages out for further processing.
If the actually code/Aiflow task that processes the messages failed, the message should be put back in the queue for further processing. This is the very basic idea of SQS Polling provided by Amazon.
Reference to SQS with AWS Lambda function, [AWS docs](https://docs.aws.amazon.com/lambda/latest/dg/with-sqs.html) states :
```
When your function *successfully* processes a batch, Lambda deletes its messages from the queue.
```
In many case, the `SQSSensor` polls the message and distributes the workload to different task, in a very similar way to AWS Lambda polling.
Thus, there should be option to disable to default behavior, which is to delete the message upon reception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr merged pull request #21159: [SQSSensor] Add opt-in to disable auto-delete messages
Posted by GitBox <gi...@apache.org>.
uranusjr merged pull request #21159:
URL: https://github.com/apache/airflow/pull/21159
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #21159: [SQSSensor] Add opt-in to disable auto-delete messages on consumption
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #21159:
URL: https://github.com/apache/airflow/pull/21159#issuecomment-1024298823
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #21159: [SQSSensor] Add opt-in to disable auto-delete messages
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #21159:
URL: https://github.com/apache/airflow/pull/21159#issuecomment-1024862029
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #21159: [SQSSensor] Add opt-in to disable auto-delete messages on consumption
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #21159:
URL: https://github.com/apache/airflow/pull/21159#issuecomment-1023366571
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] LaPetiteSouris commented on pull request #21159: [SQSSensor] Add opt-in to disable auto-delete messages on consumption
Posted by GitBox <gi...@apache.org>.
LaPetiteSouris commented on pull request #21159:
URL: https://github.com/apache/airflow/pull/21159#issuecomment-1024366594
@jimmytuc @potiuk : https://github.com/apache/airflow/pull/21159/commits/6cfca31b16043bd40c315458bfb804d7013372aa is added to address CI/CD failure on docstring. I should have checked that earlier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org