You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Martin Grigorov (JIRA)" <ji...@apache.org> on 2011/04/15 11:27:06 UTC

[jira] [Created] (WICKET-3617) Using render strategy ONE_PASS_RENDER fails for Ajax requests

Using render strategy ONE_PASS_RENDER fails for Ajax requests
-------------------------------------------------------------

                 Key: WICKET-3617
                 URL: https://issues.apache.org/jira/browse/WICKET-3617
             Project: Wicket
          Issue Type: Bug
          Components: wicket-core
    Affects Versions: 1.5-RC3
            Reporter: Martin Grigorov


I have an application which has two pages. Page A has an AjaxLink which makes some checks and either sets some error feedback and stays on the same page (e.g. login page with "Invalid user" error) or if everything is OK then redirects to page B (via setResponsePage(B.class)).
The problem comes when the current render strategy is ONE_PASS_RENDER. In this case no matter that fromUrl and toUrl are different and the request is Ajax the current code directly writes the page markup to the response.
I think it should trigger a redirect instead.
I am not sure whether it should be redirect to render or to buffer ...

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (WICKET-3617) Using render strategy ONE_PASS_RENDER fails for Ajax requests

Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-3617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Grigorov resolved WICKET-3617.
-------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.5-RC5
         Assignee: Martin Grigorov

Improved with r1127118.

> Using render strategy ONE_PASS_RENDER fails for Ajax requests
> -------------------------------------------------------------
>
>                 Key: WICKET-3617
>                 URL: https://issues.apache.org/jira/browse/WICKET-3617
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-core
>    Affects Versions: 1.5-RC3
>            Reporter: Martin Grigorov
>            Assignee: Martin Grigorov
>             Fix For: 1.5-RC5
>
>         Attachments: WICKET-3617.tgz
>
>
> I have an application which has two pages. Page A has an AjaxLink which makes some checks and either sets some error feedback and stays on the same page (e.g. login page with "Invalid user" error) or if everything is OK then redirects to page B (via setResponsePage(B.class)).
> The problem comes when the current render strategy is ONE_PASS_RENDER. In this case no matter that fromUrl and toUrl are different and the request is Ajax the current code directly writes the page markup to the response.
> I think it should trigger a redirect instead.
> I am not sure whether it should be redirect to render or to buffer ...

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (WICKET-3617) Using render strategy ONE_PASS_RENDER fails for Ajax requests

Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-3617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Grigorov updated WICKET-3617:
------------------------------------

    Attachment: WICKET-3617.tgz

A quickstart

> Using render strategy ONE_PASS_RENDER fails for Ajax requests
> -------------------------------------------------------------
>
>                 Key: WICKET-3617
>                 URL: https://issues.apache.org/jira/browse/WICKET-3617
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-core
>    Affects Versions: 1.5-RC3
>            Reporter: Martin Grigorov
>         Attachments: WICKET-3617.tgz
>
>
> I have an application which has two pages. Page A has an AjaxLink which makes some checks and either sets some error feedback and stays on the same page (e.g. login page with "Invalid user" error) or if everything is OK then redirects to page B (via setResponsePage(B.class)).
> The problem comes when the current render strategy is ONE_PASS_RENDER. In this case no matter that fromUrl and toUrl are different and the request is Ajax the current code directly writes the page markup to the response.
> I think it should trigger a redirect instead.
> I am not sure whether it should be redirect to render or to buffer ...

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (WICKET-3617) Using render strategy ONE_PASS_RENDER fails for Ajax requests

Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-3617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13032805#comment-13032805 ] 

Igor Vaynberg commented on WICKET-3617:
---------------------------------------

it should simple be a window.location('url to the page')

how that is handled on the return trip is up to the strategy.

> Using render strategy ONE_PASS_RENDER fails for Ajax requests
> -------------------------------------------------------------
>
>                 Key: WICKET-3617
>                 URL: https://issues.apache.org/jira/browse/WICKET-3617
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-core
>    Affects Versions: 1.5-RC3
>            Reporter: Martin Grigorov
>         Attachments: WICKET-3617.tgz
>
>
> I have an application which has two pages. Page A has an AjaxLink which makes some checks and either sets some error feedback and stays on the same page (e.g. login page with "Invalid user" error) or if everything is OK then redirects to page B (via setResponsePage(B.class)).
> The problem comes when the current render strategy is ONE_PASS_RENDER. In this case no matter that fromUrl and toUrl are different and the request is Ajax the current code directly writes the page markup to the response.
> I think it should trigger a redirect instead.
> I am not sure whether it should be redirect to render or to buffer ...

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira