You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by hzw19900416 <gi...@git.apache.org> on 2014/07/22 15:14:34 UTC
[GitHub] spark pull request: Fix maven test bug
GitHub user hzw19900416 opened a pull request:
https://github.com/apache/spark/pull/1529
Fix maven test bug
When running the mvn test, it will throw such exception in core module--"Class mocking requires to have cglib and objenesis librairies in the classpath"
So adding cglib and objenesis in pom.xml at core module can avoid such problem.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hzw19900416/spark bug-fix1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/1529.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1529
----
commit e476c2f80faddb4da69a0726d7ad5f9f359270a2
Author: hzw19900416 <ca...@gmail.com>
Date: 2014-07-22T13:06:36Z
Update pom.xml
commit 8473adcd55bf5715874f8d149d4038d86359b4ef
Author: hzw19900416 <ca...@gmail.com>
Date: 2014-07-22T13:09:40Z
Update pom.xml
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Fix maven test bug
Posted by hzw19900416 <gi...@git.apache.org>.
Github user hzw19900416 closed the pull request at:
https://github.com/apache/spark/pull/1529
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Fix maven test bug
Posted by hzw19900416 <gi...@git.apache.org>.
Github user hzw19900416 commented on the pull request:
https://github.com/apache/spark/pull/1529#issuecomment-49839605
I use maven-3.0.4 to run tests in SUSE11 with the commands in spark doc: "mvn package -DskipTests" and "mvn test"
If I remove this two dependencies, there are two ABORTED test cases in CacheManagerSuite and RandomSamplerSuite with the same exception as fellow:
Exception encountered when invoking run on a nested suite - Class mocking requires to have cglib and objenesis librairies in the classpath *** ABORTED ***
java.lang.RuntimeException: Class mocking requires to have cglib and objenesis librairies in the classpath
at org.easymock.internal.MocksControl.createProxyFactory(MocksControl.java:140)
at org.easymock.internal.MocksControl.createMock(MocksControl.java:58)
at org.easymock.EasyMock.createMock(EasyMock.java:103)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Fix maven test bug
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/1529#issuecomment-49745431
Interesting, I don't see any such error, and haven't as far as I can remember. I'm on OS X. The change is probably harmless anyway but what is your configuration?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Fix maven test bug
Posted by hzw19900416 <gi...@git.apache.org>.
Github user hzw19900416 commented on the pull request:
https://github.com/apache/spark/pull/1529#issuecomment-49839641
I use maven-3.0.4 to run tests in SUSE11 with the commands in spark doc: "mvn package -DskipTests" and "mvn test"
If I remove this two dependencies, there are two ABORTED test cases in CacheManagerSuite and RandomSamplerSuite with the same exception as fellow:
Exception encountered when invoking run on a nested suite - Class mocking requires to have cglib and objenesis librairies in the classpath *** ABORTED ***
java.lang.RuntimeException: Class mocking requires to have cglib and objenesis librairies in the classpath
at org.easymock.internal.MocksControl.createProxyFactory(MocksControl.java:140)
at org.easymock.internal.MocksControl.createMock(MocksControl.java:58)
at org.easymock.EasyMock.createMock(EasyMock.java:103)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Fix maven test bug
Posted by hzw19900416 <gi...@git.apache.org>.
Github user hzw19900416 commented on the pull request:
https://github.com/apache/spark/pull/1529#issuecomment-50441495
This error is due to the environment of mine. So close it.
In addition, using the "mvn package" to do the unit test while compiling is better than using "mvn test", thus "mvn test" may fail sometimes
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Fix maven test bug
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/1529#issuecomment-49909634
I've run into weird issues with EasyMock-based tests before, not unlike the ones you're running into. I wonder if it's not better to just port these tests to use Mockito instead - I had a patch to do that in the past but got rid of it when I changed the dependencies to fix my issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Fix maven test bug
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1529#issuecomment-49736923
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---