You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/06/20 19:04:06 UTC

[GitHub] [incubator-pinot] kishoreg commented on issue #4348: A template implementation for VarLengthBytesValueReaderWriter

kishoreg commented on issue #4348: A template implementation for VarLengthBytesValueReaderWriter
URL: https://github.com/apache/incubator-pinot/pull/4348#issuecomment-504145176
 
 
   Thanks Subbu.
   
   private Buffer(long size, int startIndex, PinotDataBufferMemoryManager memoryManager, String allocationContext) {
   
   Move this constructor out of this class and move it to a separate class.
   Refactor the existing MutableOffHeapByteArrayStore to use this class.
   
   Go ahead and check this in after that.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org