You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by SidneyS <gi...@git.apache.org> on 2014/10/18 03:48:55 UTC
[GitHub] cordova-ios pull request: CB-7818 - CLI builds ignore Distribution...
GitHub user SidneyS opened a pull request:
https://github.com/apache/cordova-ios/pull/114
CB-7818 - CLI builds ignore Distribution certificates
Fixed build / xcconfig defaults for CI environments. "cordova build --device --release" now builds using the default "iPhone Distribution"-type profile, as opposed to the default "cordova build --device", using the default "iPhone Developer"-type profile (https://issues.apache.org/jira/browse/CB-7818).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SidneyS/cordova-ios master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-ios/pull/114.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #114
----
commit be97c99e8ff290804044de65862f2ca9fda070b3
Author: Sidney Bofah <si...@googlemail.com>
Date: 2014-10-18T01:38:49Z
Fixed build / xcconfig defaults for CI environments. "cordova build --device --release" now builds using the "iPhone Distribution"-type profile, as opposed to the default "cordova build --device", using the default "iPhone Developer"-type profile.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: CB-7818 - CLI builds ignore Distribution...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-ios/pull/114
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: CB-7818 - CLI builds ignore Distribution...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-ios/pull/114#issuecomment-59627703
This is a great idea. However, I would err on potentially not breaking current build environments and still support build.xcconfig (esp since Microsoft's tools use this) , and treat that as "Debug", and create a new one based on Release only - build-release.xcconfig.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: CB-7818 - CLI builds ignore Distribution...
Posted by dpogue <gi...@git.apache.org>.
Github user dpogue commented on the pull request:
https://github.com/apache/cordova-ios/pull/114#issuecomment-59596942
:+1:
We've had to use before_compile hooks with the CLI to work around this issue, and it would be great to not need those hacks anymore
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: CB-7818 - CLI builds ignore Distribution...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-ios/pull/114#issuecomment-59816419
Looks great! I'll pull this in for cordova-ios 3.7.0
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: CB-7818 - CLI builds ignore Distribution...
Posted by SidneyS <gi...@git.apache.org>.
Github user SidneyS commented on the pull request:
https://github.com/apache/cordova-ios/pull/114#issuecomment-59688070
Thanks @shazron, just pushed the new version. We also use a custom build system which is regexing/patching build.xcconfig on runtime (..). I amended the commit, choice of xcconfig it is now solved via inheritance from build.xcconfig. build-debug.xcconfig is empty but can by extended as users see fit, as it overrides build.xcconfig per default. build-release.xcconfig always overrides build.xcconfig when used. Also added ASF comment section and some documentation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org