[jira] [Commented] (CXF-8436) Support reproducable builds together with @Generated

["Freeman Yue Fang (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CXF-8436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17298195#comment-17298195 ] 

Freeman Yue Fang commented on CXF-8436:
---------------------------------------

Hi [~jurrieovergoor],

Sorry, but I don't see this is a valid improvement.

1. This will break backwards compatibility.
2. With the -mark-generated, the javax.annotation.Generated is added, I believe the timestamp there is the most important info for this annotation. If you don't like the timestamp, you shouldn't use the -mark-generated flag.
3. 
{code}
-suppress-generated-date

   Prevents dumping current date as part of javadocs of the Java files generated.
{code}
It's clearly stated here the -suppress-generated-date is javadocs thing.

My 2 cents.
Freeman

> Support reproducable builds together with @Generated
> ----------------------------------------------------
>
>                 Key: CXF-8436
>                 URL: https://issues.apache.org/jira/browse/CXF-8436
>             Project: CXF
>          Issue Type: Improvement
>          Components: Tooling
>    Affects Versions: 3.3.8
>            Reporter: Jurrie Overgoor
>            Priority: Major
>
> We are trying to get our build reproducable. We use wsdl2java for generating Java classes from WSDL files, and currently have -mark-generated in effect.
> This causes problems, as there are timestamps written to the @Generated tag. I hoped that -suppress-generated-date would suppress this, but it only affects the generated Javadoc comment.
> Can we get -suppress-generated-date to also suppress outputting timestamps in the @Generated annotations?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)