You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@beam.apache.org by "Eugene Kirpichov (JIRA)" <ji...@apache.org> on 2017/04/07 22:07:41 UTC

[jira] [Created] (BEAM-1913) TFRecordIO should comply with PTransform style guide

Eugene Kirpichov created BEAM-1913:
--------------------------------------

             Summary: TFRecordIO should comply with PTransform style guide
                 Key: BEAM-1913
                 URL: https://issues.apache.org/jira/browse/BEAM-1913
             Project: Beam
          Issue Type: Bug
          Components: sdk-java-core
            Reporter: Eugene Kirpichov


https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/io/TFRecordIO.java violates a few guidelines from https://beam.apache.org/contribute/ptransform-style-guide/ :

- Use of Bound and Unbound types: the Read and Write classes themselves should be PTransform's
- Should have one static entry point per verb - read() and write()
- Both classes could benefit from AutoValue

Basically, perform similar surgery like in https://github.com/apache/beam/pull/2149 but on smaller scale since this is a much smaller connector.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)