You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hop.apache.org by "mattcasters (via GitHub)" <gi...@apache.org> on 2026/09/15 11:01:12 UTC

[PR] Force-build unpublished P2 wrappers in incremental PR builds, fixes #8387 (hop)

mattcasters opened a new pull request, #8388:
URL: https://github.com/apache/hop/pull/8388

   Fixes #8387
   
   Incremental GitHub PR builds fail while resolving `hop-ui-rcp`:
   
   ```text
   Could not find artifact org.eclipse:org.eclipse.tm4e.core:jar:2.20.0-SNAPSHOT
   ```
   
   That coordinate is Hop's unpublished `lib-p2/tm4e` wrapper (Eclipse TM4E 0.17.2 installed under the Hop version). It is never deployed (`maven.deploy.skip`, excluded from the snapshot wagon). Full `main` builds still work because GIB is disabled there.
   
   After #8356, PR jobs enable gitflow-incremental-builder. With default `buildUpstreamMode=changed`, GIB rebuilds upstreams of *directly changed* modules only. A `hop-ui` change therefore selects `hop-ui-rcp` as downstream and drops `org.eclipse.tm4e.core`, so Maven looks for the SNAPSHOT in repositories and fails.
   
   This keeps the two unpublished P2 wrappers in every incremental reactor:
   
   ```xml
   <gib.forceBuildModules>org.eclipse.tm4e.core,org.eclipse.swtbot.swt.finder</gib.forceBuildModules>
   ```
   
   SWTBot has the same unpublished wrapper shape and would hit the same hole on a different change set.
   
   Verified locally by simulating a `hop-ui`-only change with GIB enabled: the reactor now includes Eclipse TM4E Core Wrapper and `hop-ui-rcp` resolves.
   
   ------------------------
   
   - [x] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
   - [x] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`.
   - [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable.
   
   - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Force-build unpublished P2 wrappers in incremental PR builds, fixes #8387 (hop)

Posted by "mattcasters (via GitHub)" <gi...@apache.org>.
mattcasters merged PR #8388:
URL: https://github.com/apache/hop/pull/8388


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Force-build unpublished P2 wrappers in incremental PR builds, fixes #8387 (hop)

Posted by "hansva (via GitHub)" <gi...@apache.org>.
hansva commented on PR #8388:
URL: https://github.com/apache/hop/pull/8388#issuecomment-5679145852

   Thanks @mattcasters, the goal was to make our PR builds work a bit faster, the ASF is running out of build minutes because of the massive amount of projects and workflows, wanted to do our part by making our builds take up less time


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Force-build unpublished P2 wrappers in incremental PR builds, fixes #8387 (hop)

Posted by "mattcasters (via GitHub)" <gi...@apache.org>.
mattcasters commented on PR #8388:
URL: https://github.com/apache/hop/pull/8388#issuecomment-5679220613

   Let's see if this fixes it in this CI build


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org