[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1814: fix: efficient error handling in manager-api including graceful shutdown, self contained methods.

[GitBox <gi...@apache.org>]

starsz commented on a change in pull request #1814:
URL: https://github.com/apache/apisix-dashboard/pull/1814#discussion_r627474268



##########
File path: api/internal/utils/pid.go
##########
@@ -26,6 +26,9 @@ import (
 
 // WritePID write pid to the given file path.
 func WritePID(filepath string) error {
+	if _, err := os.Stat(filepath); err == nil {
+		return fmt.Errorf("instance of Manager API already running: a pid file exists in %s", filepath)

Review comment:
       Does this mean the manager can't start successfully if there exists a PID file?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org