[jira] [Updated] (HADOOP-14267) Make DistCpOptions class immutable

["Mingliang Liu (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HADOOP-14267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mingliang Liu updated HADOOP-14267:
-----------------------------------
       Resolution: Fixed
     Hadoop Flags: Incompatible change,Reviewed  (was: Incompatible change)
    Fix Version/s: 3.0.0-alpha3
           Status: Resolved  (was: Patch Available)

Committed to {{trunk}}. Thanks [~jingzhao], [~cnauroth] and [~jnp] for discussion and review.

> Make DistCpOptions class immutable
> ----------------------------------
>
>                 Key: HADOOP-14267
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14267
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: tools/distcp
>            Reporter: Mingliang Liu
>            Assignee: Mingliang Liu
>             Fix For: 3.0.0-alpha3
>
>         Attachments: HDFS-10533.000.patch, HDFS-10533.000.patch, HDFS-10533.001.patch, HDFS-10533.002.patch, HDFS-10533.003.patch, HDFS-10533.004.patch, HDFS-10533.005.patch, HDFS-10533.006.patch, HDFS-10533.007.patch, HDFS-10533.008.patch, HDFS-10533.009.patch, HDFS-10533.010.patch, HDFS-10533.011.patch, HDFS-10533.012.patch
>
>
> Currently the {{DistCpOptions}} class encapsulates all DistCp options, which may be set from command-line (via the {{OptionsParser}}) or may be set manually (eg construct an instance and call setters). As there are multiple option fields and more (e.g. [HDFS-9868], [HDFS-10314]) to add, validating them can be cumbersome. Ideally, the {{DistCpOptions}} object should be immutable. The benefits are:
> # {{DistCpOptions}} is simple and easier to use and share, plus it scales well
> # validation is automatic, e.g. manually constructed {{DistCpOptions}} gets validated before usage
> # validation error message is well-defined which does not depend on the order of setters
> This jira is to track the effort of making the {{DistCpOptions}} immutable by using a Builder pattern for creation.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org