You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/07/30 00:37:14 UTC
[GitHub] [druid] jihoonson commented on a change in pull request #11486: Add error msg to parallel task's TaskStatus
jihoonson commented on a change in pull request #11486:
URL: https://github.com/apache/druid/pull/11486#discussion_r679569432
##########
File path: indexing-service/src/test/java/org/apache/druid/indexing/common/task/batch/parallel/RangePartitionTaskKillTest.java
##########
@@ -0,0 +1,440 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.druid.indexing.common.task.batch.parallel;
+
+import com.google.common.base.Preconditions;
+import org.apache.druid.data.input.InputFormat;
+import org.apache.druid.data.input.impl.CsvInputFormat;
+import org.apache.druid.data.input.impl.DimensionsSpec;
+import org.apache.druid.data.input.impl.LocalInputSource;
+import org.apache.druid.data.input.impl.ParseSpec;
+import org.apache.druid.data.input.impl.TimestampSpec;
+import org.apache.druid.indexer.TaskState;
+import org.apache.druid.indexer.TaskStatus;
+import org.apache.druid.indexer.partitions.PartitionsSpec;
+import org.apache.druid.indexer.partitions.SingleDimensionPartitionsSpec;
+import org.apache.druid.indexing.common.LockGranularity;
+import org.apache.druid.indexing.common.TaskToolbox;
+import org.apache.druid.indexing.common.actions.TaskActionClient;
+import org.apache.druid.indexing.common.task.Task;
+import org.apache.druid.indexing.common.task.TaskResource;
+import org.apache.druid.indexing.common.task.batch.parallel.distribution.StringDistribution;
+import org.apache.druid.indexing.common.task.batch.parallel.distribution.StringSketch;
+import org.apache.druid.java.util.common.Intervals;
+import org.apache.druid.java.util.common.StringUtils;
+import org.apache.druid.java.util.common.granularity.Granularities;
+import org.apache.druid.query.aggregation.AggregatorFactory;
+import org.apache.druid.query.aggregation.LongSumAggregatorFactory;
+import org.apache.druid.segment.indexing.DataSchema;
+import org.apache.druid.segment.indexing.granularity.GranularitySpec;
+import org.apache.druid.segment.indexing.granularity.UniformGranularitySpec;
+import org.joda.time.Interval;
+import org.junit.Assert;
+import org.junit.Before;
+import org.junit.Test;
+
+import javax.annotation.Nullable;
+import java.io.File;
+import java.io.IOException;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.function.Function;
+
+/**
+ * Force and verify the failure modes for range partitioning task
+ */
+public class RangePartitionTaskKillTest extends AbstractMultiPhaseParallelIndexingTest
+{
+ private static final int NUM_PARTITION = 2;
+ private static final int NUM_ROW = 20;
+ private static final int DIM_FILE_CARDINALITY = 2;
+ private static final int YEAR = 2017;
+ private static final Interval INTERVAL_TO_INDEX = Intervals.of("%s-12/P1M", YEAR);
+ private static final String TIME = "ts";
+ private static final String DIM1 = "dim1";
+ private static final String DIM2 = "dim2";
+ private static final String LIST_DELIMITER = "|";
+ private static final String TEST_FILE_NAME_PREFIX = "test_";
+ private static final TimestampSpec TIMESTAMP_SPEC = new TimestampSpec(TIME, "auto", null);
+ private static final DimensionsSpec DIMENSIONS_SPEC = new DimensionsSpec(
+ DimensionsSpec.getDefaultSchemas(Arrays.asList(TIME, DIM1, DIM2))
+ );
+
+ private static final InputFormat INPUT_FORMAT = new CsvInputFormat(
+ Arrays.asList(TIME, DIM1, DIM2, "val"),
+ LIST_DELIMITER,
+ false,
+ false,
+ 0
+ );
+
+ private File inputDir;
+
+ public RangePartitionTaskKillTest()
+ {
+ super(LockGranularity.SEGMENT, true, DEFAULT_TRANSIENT_TASK_FAILURE_RATE, DEFAULT_TRANSIENT_API_FAILURE_RATE);
+ }
+
+ @Before
+ public void setup() throws IOException
+ {
+ inputDir = temporaryFolder.newFolder("data");
+ }
+
+ @Test(timeout = 5000L)
+ public void failsFirstPhase() throws Exception
+ {
+ int targetRowsPerSegment = NUM_ROW * 2 / DIM_FILE_CARDINALITY / NUM_PARTITION;
+ final ParallelIndexSupervisorTask task =
+ newTask(TIMESTAMP_SPEC,
+ DIMENSIONS_SPEC,
+ INPUT_FORMAT,
+ null,
+ INTERVAL_TO_INDEX,
+ inputDir,
+ TEST_FILE_NAME_PREFIX + "*",
+ new SingleDimensionPartitionsSpec(
+ targetRowsPerSegment,
+ null,
+ DIM1,
+ false
+ ),
+ 2,
+ false,
+ 0
+ );
+
+ final TaskActionClient actionClient = createActionClient(task);
+ final TaskToolbox toolbox = createTaskToolbox(task, actionClient);
+
+ prepareTaskForLocking(task);
+ Assert.assertTrue(task.isReady(actionClient));
+ task.stopGracefully(null);
+
+
+ TaskStatus taskStatus = task.runRangePartitionMultiPhaseParallel(toolbox);
+
+ Assert.assertTrue(taskStatus.isFailure());
+ Assert.assertEquals(
+ "Failed in phase[TestRunner[false]]. See task logs for details.",
Review comment:
Same comment for the phase name.
##########
File path: indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/ParallelIndexSupervisorTask.java
##########
@@ -555,14 +559,23 @@ private TaskStatus runSinglePhaseParallel(TaskToolbox toolbox) throws Exception
);
final TaskState state = runNextPhase(runner);
+ TaskStatus taskStatus;
if (state.isSuccess()) {
//noinspection ConstantConditions
publishSegments(toolbox, runner.getReports());
if (awaitSegmentAvailabilityTimeoutMillis > 0) {
waitForSegmentAvailability(runner.getReports());
}
+ taskStatus = TaskStatus.success(getId());
+ } else {
+ // there is only success or failure after running....
+ Preconditions.checkState(state.isFailure());
Review comment:
Is this a future proof for any new states that can be transitioned from running besides success and failure? Could it be nice to include some messages about what the state was?
##########
File path: indexing-service/src/test/java/org/apache/druid/indexing/common/task/batch/parallel/HashPartitionTaskKillTest.java
##########
@@ -0,0 +1,435 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.druid.indexing.common.task.batch.parallel;
+
+import com.google.common.base.Preconditions;
+import com.google.common.collect.ImmutableList;
+import org.apache.druid.data.input.InputFormat;
+import org.apache.druid.data.input.impl.CsvInputFormat;
+import org.apache.druid.data.input.impl.DimensionsSpec;
+import org.apache.druid.data.input.impl.LocalInputSource;
+import org.apache.druid.data.input.impl.ParseSpec;
+import org.apache.druid.data.input.impl.StringInputRowParser;
+import org.apache.druid.data.input.impl.TimestampSpec;
+import org.apache.druid.indexer.TaskState;
+import org.apache.druid.indexer.TaskStatus;
+import org.apache.druid.indexer.partitions.HashedPartitionsSpec;
+import org.apache.druid.indexer.partitions.PartitionsSpec;
+import org.apache.druid.indexing.common.LockGranularity;
+import org.apache.druid.indexing.common.TaskToolbox;
+import org.apache.druid.indexing.common.actions.TaskActionClient;
+import org.apache.druid.indexing.common.task.Task;
+import org.apache.druid.indexing.common.task.TaskResource;
+import org.apache.druid.java.util.common.DateTimes;
+import org.apache.druid.java.util.common.Intervals;
+import org.apache.druid.java.util.common.StringUtils;
+import org.apache.druid.java.util.common.granularity.Granularities;
+import org.apache.druid.java.util.common.guava.Comparators;
+import org.apache.druid.query.aggregation.AggregatorFactory;
+import org.apache.druid.query.aggregation.LongSumAggregatorFactory;
+import org.apache.druid.segment.indexing.DataSchema;
+import org.apache.druid.segment.indexing.granularity.GranularitySpec;
+import org.apache.druid.segment.indexing.granularity.UniformGranularitySpec;
+import org.apache.druid.segment.realtime.firehose.LocalFirehoseFactory;
+import org.joda.time.Interval;
+import org.junit.Assert;
+import org.junit.Before;
+import org.junit.Test;
+
+import javax.annotation.Nullable;
+import java.io.File;
+import java.io.IOException;
+import java.io.Writer;
+import java.nio.charset.StandardCharsets;
+import java.nio.file.Files;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.function.Function;
+
+/**
+ * Force and verify the failure modes for hash partitioning task
+ */
+public class HashPartitionTaskKillTest extends AbstractMultiPhaseParallelIndexingTest
+{
+ private static final TimestampSpec TIMESTAMP_SPEC = new TimestampSpec("ts", "auto", null);
+ private static final DimensionsSpec DIMENSIONS_SPEC = new DimensionsSpec(
+ DimensionsSpec.getDefaultSchemas(Arrays.asList("ts", "dim1", "dim2"))
+ );
+ private static final InputFormat INPUT_FORMAT = new CsvInputFormat(
+ Arrays.asList("ts", "dim1", "dim2", "val"),
+ null,
+ false,
+ false,
+ 0
+ );
+ private static final Interval INTERVAL_TO_INDEX = Intervals.of("2017-12/P1M");
+
+ private File inputDir;
+
+
+ public HashPartitionTaskKillTest()
+ {
+ super(LockGranularity.TIME_CHUNK, true, 0, 0);
+ }
+
+ @Before
+ public void setup() throws IOException
+ {
+ inputDir = temporaryFolder.newFolder("data");
+ final Set<Interval> intervals = new HashSet<>();
+ // set up data
+ for (int i = 0; i < 10; i++) {
+ try (final Writer writer =
+ Files.newBufferedWriter(new File(inputDir, "test_" + i).toPath(), StandardCharsets.UTF_8)) {
+ for (int j = 0; j < 10; j++) {
+ writer.write(StringUtils.format("2017-12-%d,%d,%d th test file\n", j + 1, i + 10, i));
+ writer.write(StringUtils.format("2017-12-%d,%d,%d th test file\n", j + 2, i + 11, i));
+ intervals.add(SEGMENT_GRANULARITY.bucket(DateTimes.of(StringUtils.format("2017-12-%d", j + 1))));
+ intervals.add(SEGMENT_GRANULARITY.bucket(DateTimes.of(StringUtils.format("2017-12-%d", j + 2))));
+ }
+ }
+ }
+
+ for (int i = 0; i < 5; i++) {
+ try (final Writer writer =
+ Files.newBufferedWriter(new File(inputDir, "filtered_" + i).toPath(), StandardCharsets.UTF_8)) {
+ writer.write(StringUtils.format("2017-12-%d,%d,%d th test file\n", i + 1, i + 10, i));
+ }
+ }
+ // sorted input intervals
+ List<Interval> inputIntervals = new ArrayList<>(intervals);
+ inputIntervals.sort(Comparators.intervalsByStartThenEnd());
+ }
+
+ @Test(timeout = 5000L)
+ public void failsInFirstPhase() throws Exception
+ {
+ final ParallelIndexSupervisorTask task =
+ newTask(TIMESTAMP_SPEC, DIMENSIONS_SPEC, INPUT_FORMAT, null, INTERVAL_TO_INDEX, inputDir,
+ "test_*",
+ new HashedPartitionsSpec(null, null, // num shards is null to force it to go to first phase
+ ImmutableList.of("dim1", "dim2")
+ ),
+ 2, false, true, 0
+ );
+
+ final TaskActionClient actionClient = createActionClient(task);
+ final TaskToolbox toolbox = createTaskToolbox(task, actionClient);
+
+ prepareTaskForLocking(task);
+ Assert.assertTrue(task.isReady(actionClient));
+ task.stopGracefully(null);
+
+ TaskStatus taskStatus = task.runHashPartitionMultiPhaseParallel(toolbox);
+
+ Assert.assertTrue(taskStatus.isFailure());
+ Assert.assertEquals(
+ "Failed in phase[TestRunner[false]]. See task logs for details.",
Review comment:
I'm unsure what the failed phase was because its name is always same. I suggest to name each phase differently, so that these tests can verify the exact message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org