You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/03/10 12:05:21 UTC
[GitHub] [flink] manner opened a new pull request #15139: [BP-1.12][hotfix][connectors/kafka] Correctly check required configs in KafkaSourceBuilder
manner opened a new pull request #15139:
URL: https://github.com/apache/flink/pull/15139
Backport of #15127 for release-1.12.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on pull request #15139: [BP-1.12][hotfix][connectors/kafka] Correctly check required configs in KafkaSourceBuilder
Posted by GitBox <gi...@apache.org>.
AHeise commented on pull request #15139:
URL: https://github.com/apache/flink/pull/15139#issuecomment-796517842
Test failure is unrelated (FLINK-21647). Merging. Thanks again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #15139: [BP-1.12][hotfix][connectors/kafka] Correctly check required configs in KafkaSourceBuilder
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #15139:
URL: https://github.com/apache/flink/pull/15139#issuecomment-795345248
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e8ea62e445bb3c8be6cebbb5898bf01b1d0581e6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e8ea62e445bb3c8be6cebbb5898bf01b1d0581e6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e8ea62e445bb3c8be6cebbb5898bf01b1d0581e6 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #15139: [BP-1.12][hotfix][connectors/kafka] Correctly check required configs in KafkaSourceBuilder
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #15139:
URL: https://github.com/apache/flink/pull/15139#issuecomment-795323110
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit e8ea62e445bb3c8be6cebbb5898bf01b1d0581e6 (Wed Mar 10 12:07:33 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15139: [BP-1.12][hotfix][connectors/kafka] Correctly check required configs in KafkaSourceBuilder
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15139:
URL: https://github.com/apache/flink/pull/15139#issuecomment-795345248
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e8ea62e445bb3c8be6cebbb5898bf01b1d0581e6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14407",
"triggerID" : "e8ea62e445bb3c8be6cebbb5898bf01b1d0581e6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e8ea62e445bb3c8be6cebbb5898bf01b1d0581e6 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14407)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15139: [BP-1.12][hotfix][connectors/kafka] Correctly check required configs in KafkaSourceBuilder
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15139:
URL: https://github.com/apache/flink/pull/15139#issuecomment-795345248
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e8ea62e445bb3c8be6cebbb5898bf01b1d0581e6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14407",
"triggerID" : "e8ea62e445bb3c8be6cebbb5898bf01b1d0581e6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e8ea62e445bb3c8be6cebbb5898bf01b1d0581e6 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14407)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise merged pull request #15139: [BP-1.12][hotfix][connectors/kafka] Correctly check required configs in KafkaSourceBuilder
Posted by GitBox <gi...@apache.org>.
AHeise merged pull request #15139:
URL: https://github.com/apache/flink/pull/15139
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org