[jira] [Resolved] (SAMZA-44) Change "state topic" phrasing in KafkaCheckpointManager

["Chris Riccomini (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SAMZA-44?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Riccomini resolved SAMZA-44.
----------------------------------

       Resolution: Fixed
    Fix Version/s: 0.7.0

+1 Merged and committed. Thanks!

> Change "state topic" phrasing in KafkaCheckpointManager
> -------------------------------------------------------
>
>                 Key: SAMZA-44
>                 URL: https://issues.apache.org/jira/browse/SAMZA-44
>             Project: Samza
>          Issue Type: Bug
>          Components: kafka
>    Affects Versions: 0.6.0
>            Reporter: Chris Riccomini
>            Assignee: Zhijie Shen
>              Labels: newbie
>             Fix For: 0.7.0
>
>         Attachments: SAMZA-44.1.patch
>
>
> Currently, we refer to stateTopic and "state topic" in KafkaCheckpointManager. For example:
> {code}
> if (offset <= 0) {
>   info("Got offset 0 (no messages in state topic) for topic %s and partition %s, so returning null. If you expected the state topic to have messages, you're probably going to lose data." format (stateTopic, partition))
>   return null
> }
> {code}
> This is a misleading phrase, and variable name. We should rename all mentions of state topic to checkpoint topic, so it doesn't get confused with ACTUAL state topics (LoggedStores).



--
This message was sent by Atlassian JIRA
(v6.2#6252)