You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "Alonexc (via GitHub)" <gi...@apache.org> on 2023/02/02 03:07:58 UTC
[GitHub] [incubator-eventmesh] Alonexc opened a new issue, #3017: [Enhancement] Found reliance on default encoding: String.getBytes() [MetricsHandler]
Alonexc opened a new issue, #3017:
URL: https://github.com/apache/incubator-eventmesh/issues/3017
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/eventmesh/issues?q=is%3Aissue) and found no similar issues.
### Enhancement Request
located at:
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/admin/handler/MetricsHandler.java line 123,124,134,135,
analysis and explanation:
Found a call to a method which will perform a byte to String (or String to byte) conversion, and will assume that the default platform encoding is suitable. This will cause the application behaviour to vary between platforms.
### Describe the solution you'd like
Use an alternative API and specify a charset name or Charset object explicitly.
e.g.
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 closed issue #3017: [Enhancement] Found reliance on default encoding: String.getBytes() [MetricsHandler]
Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 closed issue #3017: [Enhancement] Found reliance on default encoding: String.getBytes() [MetricsHandler]
URL: https://github.com/apache/incubator-eventmesh/issues/3017
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] Bannirui commented on issue #3017: [Enhancement] Found reliance on default encoding: String.getBytes() [MetricsHandler]
Posted by "Bannirui (via GitHub)" <gi...@apache.org>.
Bannirui commented on issue #3017:
URL: https://github.com/apache/incubator-eventmesh/issues/3017#issuecomment-1431535042
BTW, other handlers called `xxxHandler` are like this, e.g., TCPClientHandler, HTTPClientHandler...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] Alonexc commented on issue #3017: [Enhancement] Found reliance on default encoding: String.getBytes() [MetricsHandler]
Posted by "Alonexc (via GitHub)" <gi...@apache.org>.
Alonexc commented on issue #3017:
URL: https://github.com/apache/incubator-eventmesh/issues/3017#issuecomment-1432337017
@Bannirui Yes, I have mentioned the related issues, if you are interested in fixing them, you can leave a comment under related issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org