You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by ag...@apache.org on 2023/01/26 21:45:49 UTC

[arrow-datafusion] branch master updated: Optimize returned plan in roundtrip_fill_na function (#5083)

This is an automated email from the ASF dual-hosted git repository.

agrove pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow-datafusion.git


The following commit(s) were added to refs/heads/master by this push:
     new 3a1f03378 Optimize returned plan in roundtrip_fill_na function (#5083)
3a1f03378 is described below

commit 3a1f033783973d3e414a258c77f6f102abd4ffc3
Author: Nuttiiya Seekhao <37...@users.noreply.github.com>
AuthorDate: Thu Jan 26 16:45:43 2023 -0500

    Optimize returned plan in roundtrip_fill_na function (#5083)
---
 datafusion/substrait/tests/roundtrip.rs | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/datafusion/substrait/tests/roundtrip.rs b/datafusion/substrait/tests/roundtrip.rs
index fcf01f6c6..febc08ac7 100644
--- a/datafusion/substrait/tests/roundtrip.rs
+++ b/datafusion/substrait/tests/roundtrip.rs
@@ -67,7 +67,6 @@ mod tests {
         roundtrip("SELECT * FROM data WHERE d AND a > 1").await
     }
 
-    #[ignore] // tracked in https://github.com/apache/arrow-datafusion/issues/4897
     #[tokio::test]
     async fn select_with_limit() -> Result<()> {
         roundtrip_fill_na("SELECT * FROM data LIMIT 100").await
@@ -221,6 +220,7 @@ mod tests {
         let plan1 = df.into_optimized_plan()?;
         let proto = to_substrait_plan(&plan1)?;
         let plan2 = from_substrait_plan(&mut ctx, &proto).await?;
+        let plan2 = ctx.state().optimize(&plan2)?;
 
         // Format plan string and replace all None's with 0
         let plan1str = format!("{plan1:?}").replace("None", "0");
@@ -260,7 +260,7 @@ mod tests {
         let plan = df.into_optimized_plan()?;
         let proto = to_substrait_plan(&plan)?;
         let plan2 = from_substrait_plan(&mut ctx, &proto).await?;
-        let plan2 = ctx.optimize(&plan2)?;
+        let plan2 = ctx.state().optimize(&plan2)?;
 
         println!("{plan:#?}");
         println!("{plan2:#?}");