You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Sebb (JIRA)" <ji...@apache.org> on 2012/05/29 21:39:23 UTC
[jira] [Reopened] (MATH-793) OrderedTuple#hashCode() uses casting
instead of boxing
[ https://issues.apache.org/jira/browse/MATH-793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sebb reopened MATH-793:
-----------------------
The hash code calculation added in r1343920 is a bit strange.
The way it is normally done is as follows:
{code}
int oddMult = 37; // constant odd multiplier
int hashCode = 17; // seed (odd)
hashCode = hashCode * oddMult + field1.hashcode;
hashCode = hashCode * oddMult + field2.hashcode;
{code}
> OrderedTuple#hashCode() uses casting instead of boxing
> ------------------------------------------------------
>
> Key: MATH-793
> URL: https://issues.apache.org/jira/browse/MATH-793
> Project: Commons Math
> Issue Type: Bug
> Environment: OrderedTuple#hashCode() is as follows:
> {code}
> public int hashCode() {
> return Arrays.hashCode(components) ^
> ((Integer) offset).hashCode() ^
> ((Integer) lsb).hashCode() ^
> ((Boolean) posInf).hashCode() ^
> ((Boolean) negInf).hashCode() ^
> ((Boolean) nan).hashCode();
> }
> {code}
> This is not the correct way to convert primitives to their object equivalents.
> {code}
> ((Integer) x).hashCode() == x
> Boolean#hashCode() is defined as
> value ? 1231 : 1237
> {code}
> Note that this error won't be found unless the compiler emits warnings for boxing.
> Reporter: Sebb
> Fix For: 3.1
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira