You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by jc...@apache.org on 2008/12/21 22:37:02 UTC
svn commit: r728513 - in
/wicket/trunk/wicket/src/main/java/org/apache/wicket: ajax/wicket-ajax.js
util/string/JavascriptUtils.java
Author: jcompagner
Date: Sun Dec 21 13:37:02 2008
New Revision: 728513
URL: http://svn.apache.org/viewvc?rev=728513&view=rev
Log:
merged from 1.3, remove the escaping in the ajax xml of javascript before eval
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/ajax/wicket-ajax.js
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/string/JavascriptUtils.java
Modified: wicket/trunk/wicket/src/main/java/org/apache/wicket/ajax/wicket-ajax.js
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/ajax/wicket-ajax.js?rev=728513&r1=728512&r2=728513&view=diff
==============================================================================
--- wicket/trunk/wicket/src/main/java/org/apache/wicket/ajax/wicket-ajax.js (original)
+++ wicket/trunk/wicket/src/main/java/org/apache/wicket/ajax/wicket-ajax.js Sun Dec 21 13:37:02 2008
@@ -1442,6 +1442,9 @@
} else {
// serialize the element content to string
var text = Wicket.DOM.serializeNodeChildren(node);
+ // get rid of prefix and suffix, they are not eval-d correctly
+ text = text.replace(/^<!--\/\*--><!\[CDATA\[\/\*><!--\*\//, "");
+ text = text.replace(/\/\*-->]]>\*\/$/, "");
var id = node.getAttribute("id");
Modified: wicket/trunk/wicket/src/main/java/org/apache/wicket/util/string/JavascriptUtils.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/util/string/JavascriptUtils.java?rev=728513&r1=728512&r2=728513&view=diff
==============================================================================
--- wicket/trunk/wicket/src/main/java/org/apache/wicket/util/string/JavascriptUtils.java (original)
+++ wicket/trunk/wicket/src/main/java/org/apache/wicket/util/string/JavascriptUtils.java Sun Dec 21 13:37:02 2008
@@ -33,10 +33,16 @@
/** Script close tag */
public final static String SCRIPT_CLOSE_TAG = "\n/*-->]]>*/</script>\n";
- /** Script open tag */
+ /**
+ * Script open tag. If this tag is changed, also update
+ * Wicket.Head.Contributor.processScript() function from wicket-ajax.js
+ */
public final static String SCRIPT_CONTENT_PREFIX = "<!--/*--><![CDATA[/*><!--*/\n";
- /** Script close tag */
+ /**
+ * Script close tag. If this tag is changed, also update
+ * Wicket.Head.Contributor.processScript() function from wicket-ajax.js
+ */
public final static String SCRIPT_CONTENT_SUFFIX = "\n/*-->]]>*/";